Skip to content

feat!: Add ListenerClass.spec.serviceOverrides field#1142

Merged
sbernauer merged 3 commits intomainfrom
feat/listener-service-overrides
Jan 20, 2026
Merged

feat!: Add ListenerClass.spec.serviceOverrides field#1142
sbernauer merged 3 commits intomainfrom
feat/listener-service-overrides

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 19, 2026

Description

Part of stackabletech/listener-operator#324 and stackabletech/issues#712.
Decision was in stackabletech/listener-operator#330

Will open a PR at listener-op for the implementation

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Jan 19, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jan 19, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 19, 2026
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 19, 2026
@sbernauer sbernauer added this pull request to the merge queue Jan 20, 2026
Merged via the queue into main with commit a9ad15f Jan 20, 2026
5 checks passed
@sbernauer sbernauer deleted the feat/listener-service-overrides branch January 20, 2026 12:06
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jan 20, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants