Skip to content

feat: Support serviceOverrides on the ListenerClass#365

Merged
sbernauer merged 4 commits intomainfrom
test/object-overrides
Jan 20, 2026
Merged

feat: Support serviceOverrides on the ListenerClass#365
sbernauer merged 4 commits intomainfrom
test/object-overrides

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 19, 2026

Description

Part of #324 and stackabletech/issues#712.
Decision was in #330.

Needs stackabletech/operator-rs#1142 from operator-rs

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Release notes

Added:

You can now configure serviceOverrides on ListenerClass.spec.serviceOverrides similar to podOverrides on your stacklets. This enables you to make arbitrary modification to the created Services.

@sbernauer sbernauer self-assigned this Jan 19, 2026
@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering Jan 19, 2026
@sbernauer sbernauer changed the title test: Add kuttl test for objectOverrides feat: Support serviceOverride on the ListenerClass Jan 19, 2026
@sbernauer sbernauer changed the title feat: Support serviceOverride on the ListenerClass feat: Support serviceOverrides on the ListenerClass Jan 19, 2026
@sbernauer sbernauer added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 19, 2026
@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jan 19, 2026
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 20, 2026
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Jan 20, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jan 20, 2026
Merged via the queue into main with commit 837881f Jan 20, 2026
12 checks passed
@sbernauer sbernauer deleted the test/object-overrides branch January 20, 2026 13:22
@lfrancke
Copy link
Member

lfrancke commented Feb 4, 2026

I do know we had a decision about this and voted on it etc..
Just wondering: Does this also support objectOverrides?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Feb 4, 2026
@sbernauer
Copy link
Member Author

The ListenerClass only describes how services should look like, so it only has a serviceOverrides.
The Listener however has objectOverrides.

We might be able to add objectOverrides to the ListenerClass as well, but that would make things a bit more complicated, as we would need to take objectOverrides from the ListenerClass as well as the Listener into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Status: Acceptance: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants