-
Notifications
You must be signed in to change notification settings - Fork 2k
Added extra vault logging #22994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
russell-stern
wants to merge
3
commits into
develop
Choose a base branch
from
vault/improve_logging
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added extra vault logging #22994
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "chainlink": patch | ||
| --- | ||
|
|
||
| Add structured vault request ID logging across capability, OCR plugin, and workflow secrets paths. #internal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package vaultutils | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/smartcontractkit/chainlink-common/pkg/capabilities" | ||
| ) | ||
|
|
||
| const subscriptionPhaseKey = "subscription" | ||
|
|
||
| // BuildWorkflowGetSecretsRequestID returns the pending-queue / OCR request ID for a | ||
| // workflow GetSecrets call. This is the only place this format should be defined. | ||
| // | ||
| // We need to generate sufficiently unique IDs accounting for two cases: | ||
| // 1. called during the subscription phase, in which case the executionID will be blank | ||
| // 2. called during execution, in which case it'll be present. | ||
| // The reference ID is unique per phase, so we need to differentiate when generating | ||
| // an ID. | ||
| func BuildWorkflowGetSecretsRequestID(md capabilities.RequestMetadata) string { | ||
| phaseOrExecution := md.WorkflowExecutionID | ||
| if phaseOrExecution == "" { | ||
| phaseOrExecution = subscriptionPhaseKey | ||
| } | ||
| return fmt.Sprintf("%s::%s::%s", md.WorkflowID, phaseOrExecution, md.ReferenceID) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package vaultutils | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
|
|
||
| "github.com/smartcontractkit/chainlink-common/pkg/capabilities" | ||
| ) | ||
|
|
||
| func TestBuildWorkflowGetSecretsRequestID(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| md capabilities.RequestMetadata | ||
| want string | ||
| }{ | ||
| { | ||
| name: "execution path", | ||
| md: capabilities.RequestMetadata{ | ||
| WorkflowID: "wf-1", | ||
| WorkflowExecutionID: "abc123sha", | ||
| ReferenceID: "42", | ||
| }, | ||
| want: "wf-1::abc123sha::42", | ||
| }, | ||
| { | ||
| name: "subscription path", | ||
| md: capabilities.RequestMetadata{ | ||
| WorkflowID: "wf-1", | ||
| ReferenceID: "7", | ||
| }, | ||
| want: "wf-1::subscription::7", | ||
| }, | ||
| { | ||
| name: "gate off empty workflow ID", | ||
| md: capabilities.RequestMetadata{ | ||
| WorkflowExecutionID: "abc123sha", | ||
| ReferenceID: "42", | ||
| }, | ||
| want: "::abc123sha::42", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| assert.Equal(t, tt.want, BuildWorkflowGetSecretsRequestID(tt.md)) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also move this comment to the request_id file?