Added extra vault logging#22994
Conversation
product-security-plaid-production
Bot
requested review from
bolekk,
patrickhuie19,
prashantkumar1982 and
vyzaldysanchez
and removed request for
prashantkumar1982
|
👋 russell-stern, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
|
|
| } | ||
|
|
||
| // We need to generate sufficiently unique IDs accounting for two cases: | ||
| // 1. called during the subscription phase, in which case the executionID will be blank |
There was a problem hiding this comment.
Can you also move this comment to the request_id file?
| { | ||
| name: "subscription path", | ||
| md: capabilities.RequestMetadata{ | ||
| WorkflowID: "wf-1", |
There was a problem hiding this comment.
look at these warnings, they might need lint fixes
| } | ||
| if propagateOrgIDMeta, _ := cresettings.Default.PropagateOrgIDInRequestMetadata.GetOrDefault(ctx, s.creSettingsGetter); propagateOrgIDMeta && s.orgID != "" { | ||
| metadata.OrgID = s.orgID | ||
| // WorkflowID is under this gate because we previously skipped setting workflowID on SecretsFetcher entirely. Now setting it safely. |
There was a problem hiding this comment.
can you add this comment to the new code too?
just so people can understand why this field is inside this flag
|
2 participants
No description provided.