This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat: add auth_oauth#132
Open
Blckbrry-Pi wants to merge 2 commits into
Open
Conversation
This was referenced Jul 20, 2024
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Blckbrry-Pi and the rest of your teammates on |
Blckbrry-Pi
changed the title
auth_username_pasword moduleauth_username_pasword module
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
7a771d2 to
a84215f
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
461712a to
2873938
Compare
Blckbrry-Pi
changed the title
auth_username_pasword moduleauth_username_pasword, auth_email, and auth_oauth
NathanFlurry
suggested changes
Aug 2, 2024
| @@ -0,0 +1,11 @@ | |||
| export interface Config { | |||
Member
There was a problem hiding this comment.
let's rename this to customProviders and add pre-configured blocks for google, facebook, etc.
see the repo i sent an while back for reference on pre-made configs
Contributor
Author
There was a problem hiding this comment.
Will do. This will require some reworking however, and IMO that functionality should be provided by a google or facebook module.
Member
There was a problem hiding this comment.
ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
85377b5 to
5520319
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
a84215f to
564ae91
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
5520319 to
3b421b9
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
564ae91 to
1b445c7
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
3b421b9 to
ea83953
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
1b445c7 to
91cb526
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
4 times, most recently
from
5b70e06 to
ef45e3e
Compare
NathanFlurry
suggested changes
Aug 4, 2024
| @@ -0,0 +1,11 @@ | |||
| export interface Config { | |||
Member
There was a problem hiding this comment.
ok cool let's get the interface stable then by just renaming this to "customProviders" and add presets later
NathanFlurry
suggested changes
Aug 5, 2024
| IDENTITY_INFO_PASSWORDLESS, | ||
| } from "./provider.ts"; | ||
|
|
||
| export async function ensureNotAssociated( |
Member
There was a problem hiding this comment.
repost: this is very very expensive, it does at least 3 round trips to the database before doing anything else in the request. we should expose a batch api on identities module for this.
to answer the q: it should be very easy to pass multiple identity types to the query so it can be configurable. but also, that won't be a breaking change, so go for the simpler option.
| return output; | ||
| } | ||
|
|
||
| export function generateRandomCodeSecure( |
Member
There was a problem hiding this comment.
neat. we need ot refactor tokens itself to use this function since it still depends on an insecure version.
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
91cb526 to
7677207
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
2 times, most recently
from
eac22ac to
53d1543
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
7677207 to
392079a
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
53d1543 to
709f613
Compare
Blckbrry-Pi
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
392079a to
b504d85
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
2 times, most recently
from
32352b5 to
658d5a4
Compare
NathanFlurry
force-pushed
the
07-04-feat_create_the_user_passwords_module
branch
from
b504d85 to
8358d72
Compare
NathanFlurry
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
2 times, most recently
from
b85d1e6 to
64571da
Compare
NathanFlurry
changed the base branch from
07-04-feat_create_the_user_passwords_module
to
08-23-feat_email_email_link_email_password_email_passwordless_and_username_password_auth_methods
NathanFlurry
changed the title
auth_username_pasword, auth_email, and auth_oauthauth_oauth
NathanFlurry
changed the base branch from
08-23-feat_email_email_link_email_password_email_passwordless_and_username_password_auth_methods
to
graphite-base/132
NathanFlurry
force-pushed
the
graphite-base/132
branch
from
515a6d2 to
0f9152f
Compare
NathanFlurry
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
64571da to
c724d76
Compare
NathanFlurry
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
c724d76 to
7767658
Compare
Blckbrry-Pi
force-pushed
the
07-20-eat_create_the_auth_username_pasword_module
branch
from
7767658 to
c9ea5ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.