Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat: Create the user_passwords module#127

Merged
NathanFlurry merged 1 commit into
mainfrom
07-04-feat_create_the_user_passwords_module
Aug 24, 2024
Merged

feat: Create the user_passwords module#127
NathanFlurry merged 1 commit into
mainfrom
07-04-feat_create_the_user_passwords_module

Conversation

@Blckbrry-Pi

@Blckbrry-Pi Blckbrry-Pi commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Jul 5, 2024
Closed
Merged
Closed
Closed
Closed
@Blckbrry-Pi Graphite App

Blckbrry-Pi commented Jul 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Blckbrry-Pi and the rest of your teammates on Graphite Graphite

@Blckbrry-Pi Blckbrry-Pi mentioned this pull request Jul 5, 2024
Closed
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from c02a755 to efc852f Compare July 5, 2024 03:43
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 36fcbcd to a603a06 Compare July 5, 2024 03:43
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from efc852f to bfd5d25 Compare July 5, 2024 03:51
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from a603a06 to cc6b5aa Compare July 5, 2024 03:51
@Blckbrry-Pi Blckbrry-Pi marked this pull request as ready for review July 10, 2024 19:41
MasterPtato
MasterPtato approved these changes Jul 11, 2024
View reviewed changes
Comment thread modules/user_passwords/scripts/verify.ts Outdated
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from bfd5d25 to ce34e98 Compare July 19, 2024 23:48
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from cc6b5aa to 7a771d2 Compare July 19, 2024 23:48
This was referenced Jul 19, 2024
Closed
Open
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 7a771d2 to a84215f Compare July 20, 2024 17:42
NathanFlurry
NathanFlurry reviewed Aug 2, 2024
View reviewed changes
Comment thread modules/user_passwords/utils/scrypt.ts Outdated
NathanFlurry
NathanFlurry reviewed Aug 2, 2024
View reviewed changes
Comment thread modules/user_passwords/utils/scrypt.ts
NathanFlurry
NathanFlurry reviewed Aug 2, 2024
View reviewed changes

@NathanFlurry NathanFlurry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on this, thanks for taking the time to make sure this impl is correct

Comment thread modules/user_passwords/utils/common.ts Outdated
NathanFlurry
NathanFlurry suggested changes Aug 2, 2024
View reviewed changes

@NathanFlurry NathanFlurry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops forgot to request

NathanFlurry
NathanFlurry suggested changes Aug 2, 2024
View reviewed changes
Comment thread modules/user_passwords/module.json
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from ce34e98 to 7a38516 Compare August 3, 2024 17:47
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch 2 times, most recently from 564ae91 to 1b445c7 Compare August 3, 2024 21:59
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from 7a38516 to a119950 Compare August 3, 2024 22:57
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 1b445c7 to 91cb526 Compare August 3, 2024 22:57
NathanFlurry
NathanFlurry suggested changes Aug 4, 2024
View reviewed changes
Comment thread modules/user_passwords/utils/scrypt.ts
Comment thread modules/user_passwords/utils/common.ts Outdated
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 91cb526 to 7677207 Compare August 7, 2024 21:32
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from a119950 to 7a04e0a Compare August 7, 2024 22:03
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 7677207 to 392079a Compare August 7, 2024 22:08
@Blckbrry-Pi Blckbrry-Pi force-pushed the 06-29-feat_create_the_auth_provider_module branch from 7a04e0a to 68f1b5e Compare August 7, 2024 22:09
@Blckbrry-Pi Blckbrry-Pi force-pushed the 07-04-feat_create_the_user_passwords_module branch from 392079a to b504d85 Compare August 7, 2024 22:09
@NathanFlurry NathanFlurry force-pushed the 06-29-feat_create_the_auth_provider_module branch from 68f1b5e to faed173 Compare August 24, 2024 02:47
@NathanFlurry NathanFlurry force-pushed the 07-04-feat_create_the_user_passwords_module branch from b504d85 to 8358d72 Compare August 24, 2024 02:47
@NathanFlurry NathanFlurry mentioned this pull request Aug 24, 2024
Merged
@NathanFlurry Graphite App

NathanFlurry commented Aug 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Merge activity

  • Aug 23, 10:59 PM EDT: @NathanFlurry started a stack merge that includes this pull request via Graphite.
  • Aug 23, 11:04 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 11:05 PM EDT: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry changed the base branch from 06-29-feat_create_the_auth_provider_module to graphite-base/127 August 24, 2024 03:00
@NathanFlurry NathanFlurry changed the base branch from graphite-base/127 to main August 24, 2024 03:02
@NathanFlurry NathanFlurry force-pushed the 07-04-feat_create_the_user_passwords_module branch from 8358d72 to 2674ef5 Compare August 24, 2024 03:03
@NathanFlurry NathanFlurry merged commit 7d12d24 into main Aug 24, 2024
@github-actions github-actions Bot mentioned this pull request Aug 24, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abcxff abcxff Awaiting requested review from abcxff
2 more reviewers
@MasterPtato MasterPtato MasterPtato approved these changes
@NathanFlurry NathanFlurry NathanFlurry approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Blckbrry-Pi @NathanFlurry @MasterPtato