Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ assert-json-diff = { version = "2" }
async-trait = { version = "0.1" }
aws-lc-rs = { version = "1" }
axum = { version = "0.8" }
axum-test = { version = "20" }
axum-test = { version = "21" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md says every commit needs a DCO sign-off via git commit -s, but I checked git show -s --format=full 1788e87ccdae2f305c320e4b55670ae7e4b1ffa9 and this commit has no Signed-off-by: trailer. In this repo that will block the DCO gate until the commit is recreated with the sign-off.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to be created with git commit -s, and I checked git show -s --format=full 7ad6fd42789a7100fa0a761f04f14e61ac5eee36: this new commit still has no Signed-off-by: trailer. That will block the DCO gate for this dependency bump until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the current commit with git show -s --format=full c7911d2d228e02d7b7db53126855a40f0f08d01f and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this replacement commit hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested commit with git show -s --format=full 442faf6aefd5918567bc454d953746bc3553fdfe and it has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this replacement hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but the requested replacement commit ecbda1712707826ef38b04ac4d97a64e8cb3172c still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 45fb2736e599437953f9eaf2ea98dc1cbfd6e28a with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 2ffef7a6a15313e89711e628345be6772e3c4df3 with git show -s --format=full and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit f6293a69194682d176fbe427b6100210a57c63ee with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 4deead3b622aadaaddfe0d5bbc9e09147c975c17 with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s; I checked the requested replacement commit b0f708af9612d90e374cf41fc4f96358fe626a98 with git show -s --format='%B%n%(trailers:key=Signed-off-by)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

When this replacement commit is in the PR, the DCO workflow will fail because .github/workflows/dco.yml:27-38 checks every non-merge commit for a Signed-off-by: trailer, and git show -s --format='%B%n%(trailers:key=Signed-off-by)' f3ef9c1299ec3bb09a1a30dbb5bdb00ab76bcf0f shows no such trailer. Fresh evidence versus the earlier comments is that this requested replacement hash is also unsigned, so recreate the commit with git commit -s.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

When this exact replacement commit is in the PR, .github/workflows/dco.yml:27-38 will fail because it checks every non-merge commit for a Signed-off-by: trailer, and git show -s --format='%B%n%(trailers:key=Signed-off-by)' 718a84f825db470361718cb7099b49b65628ed36 shows no such trailer. Fresh evidence versus the earlier comments is that the requested replacement hash is also unsigned, so recreate it with git commit -s.

Useful? React with 👍 / 👎.

base64 = { version = "0.22" }
bytes = { version = "1" }
calamine = { version = "0.35" }
Expand Down
2 changes: 1 addition & 1 deletion crates/registry-notary-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ tracing.workspace = true

[dev-dependencies]
axum.workspace = true
axum-test = { version = "20" }
axum-test = { version = "21" }
registry-platform-crypto.workspace = true
registry-platform-sdjwt.workspace = true
registry-notary-server = { workspace = true, features = ["registry-notary-cel"] }
Expand Down
2 changes: 1 addition & 1 deletion crates/registry-notary-server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ utoipa.workspace = true
zeroize.workspace = true

[dev-dependencies]
axum-test = { version = "20" }
axum-test = { version = "21" }
chrono = { version = "0.4" }
registry-notary-client = { workspace = true, features = ["verifier"] }
registry-platform-testing = { workspace = true, features = ["test-utils"] }
Expand Down
2 changes: 1 addition & 1 deletion crates/registry-notary/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ tracing-subscriber.workspace = true
ulid.workspace = true

[dev-dependencies]
axum-test = { version = "20" }
axum-test = { version = "21" }
chrono = { version = "0.4" }
jsonschema.workspace = true
registry-platform-authcommon.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/registry-relay/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ rustix.workspace = true
# ─── dev / test ──────────────────────────────────────────────────────────────
[dev-dependencies]
aws-lc-rs = { version = "1" }
axum-test = { version = "20" }
axum-test = { version = "21" }
assert-json-diff = { version = "2" }
chrono = { version = "0.4" }
registry-notary-core.workspace = true
Expand Down
Loading