build(deps): Bump axum-test from 20.1.0 to 21.0.0#185
Conversation
0e34173 to
a52560e
Compare
5ab2756 to
2695441
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2695441c26
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md says every commit needs a DCO sign-off via git commit -s, but I checked git show -s --format=full 1788e87ccdae2f305c320e4b55670ae7e4b1ffa9 and this commit has no Signed-off-by: trailer. In this repo that will block the DCO gate until the commit is recreated with the sign-off.
Useful? React with 👍 / 👎.
828867e to
9c3e9e2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c3e9e2a76
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to be created with git commit -s, and I checked git show -s --format=full 7ad6fd42789a7100fa0a761f04f14e61ac5eee36: this new commit still has no Signed-off-by: trailer. That will block the DCO gate for this dependency bump until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
9c3e9e2 to
1163ecd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1163ecdb0c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the current commit with git show -s --format=full c7911d2d228e02d7b7db53126855a40f0f08d01f and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this replacement commit hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
1163ecd to
966d7ee
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 966d7ee073
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested commit with git show -s --format=full 442faf6aefd5918567bc454d953746bc3553fdfe and it has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this replacement hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
966d7ee to
496d427
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 496d427b7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but the requested replacement commit ecbda1712707826ef38b04ac4d97a64e8cb3172c still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
496d427 to
b95ccc4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b95ccc4bf3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 45fb2736e599437953f9eaf2ea98dc1cbfd6e28a with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
b95ccc4 to
44e7145
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e71451e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 2ffef7a6a15313e89711e628345be6772e3c4df3 with git show -s --format=full and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
44e7145 to
c7b4290
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7b429099a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit f6293a69194682d176fbe427b6100210a57c63ee with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
c7b4290 to
f26d316
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f26d316ad2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s, but I checked the requested replacement commit 4deead3b622aadaaddfe0d5bbc9e09147c975c17 with git show -s --format='%B%n%(trailers)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
f26d316 to
b8e8cfe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8e8cfea57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
The root AGENTS.md requires every commit to include a DCO sign-off via git commit -s; I checked the requested replacement commit b0f708af9612d90e374cf41fc4f96358fe626a98 with git show -s --format='%B%n%(trailers:key=Signed-off-by)' and it still has no Signed-off-by: trailer. Fresh evidence versus the earlier comments is that this current hash is also unsigned, so the DCO gate will remain blocked until the commit is recreated with the trailer.
Useful? React with 👍 / 👎.
b8e8cfe to
189c55d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 189c55df16
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
When this replacement commit is in the PR, the DCO workflow will fail because .github/workflows/dco.yml:27-38 checks every non-merge commit for a Signed-off-by: trailer, and git show -s --format='%B%n%(trailers:key=Signed-off-by)' f3ef9c1299ec3bb09a1a30dbb5bdb00ab76bcf0f shows no such trailer. Fresh evidence versus the earlier comments is that this requested replacement hash is also unsigned, so recreate the commit with git commit -s.
Useful? React with 👍 / 👎.
Bumps [axum-test](https://github.com/JosephLenton/axum-test) from 20.1.0 to 21.0.0. - [Release notes](https://github.com/JosephLenton/axum-test/releases) - [Commits](https://github.com/JosephLenton/axum-test/commits) --- updated-dependencies: - dependency-name: axum-test dependency-version: 21.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
189c55d to
8f68922
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f6892222f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| aws-lc-rs = { version = "1" } | ||
| axum = { version = "0.8" } | ||
| axum-test = { version = "20" } | ||
| axum-test = { version = "21" } |
There was a problem hiding this comment.
When this exact replacement commit is in the PR, .github/workflows/dco.yml:27-38 will fail because it checks every non-merge commit for a Signed-off-by: trailer, and git show -s --format='%B%n%(trailers:key=Signed-off-by)' 718a84f825db470361718cb7099b49b65628ed36 shows no such trailer. Fresh evidence versus the earlier comments is that the requested replacement hash is also unsigned, so recreate it with git commit -s.
Useful? React with 👍 / 👎.
|
Closing per maintainer direction. This automated dependency update is not part of the frozen beta-15 release scope and is not intended for later merge. Re-open or regenerate only after an explicit dependency review. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps axum-test from 20.1.0 to 21.0.0.
Commits