Remove linter action redundancies#563
Draft
bsavitzky wants to merge 4937 commits intopy4dstem:devfrom
Draft
Conversation
Former-commit-id: 466343b
Former-commit-id: 4f97b81
Former-commit-id: a48093f
Adding requested docstrings Former-commit-id: e21541a
Former-commit-id: b067fc1
Former-commit-id: 3096f6c
Former-commit-id: d7ac9e1
Former-commit-id: b19d173
Former-commit-id: e07dddd
adding "sphinx_rtd_theme" to conf.py Former-commit-id: 69df1a4
Adding grain clustering for ACOM Former-commit-id: b35d8ec
Former-commit-id: f2c21d5
Former-commit-id: d6f4799
Former-commit-id: 74c60d4
Former-commit-id: 7c3a0d8
Former-commit-id: 23204aa
Former-commit-id: af9f526
Former-commit-id: 871e0a5
Former-commit-id: 84a2067
Former-commit-id: 0978c4b
Former-commit-id: f20fab2
Former-commit-id: c9ac5db
Former-commit-id: 00991c9
Former-commit-id: 31af429
Former-commit-id: 43289e3
Former-commit-id: 35d076f
Former-commit-id: c06ca46
Contributor
|
Expect a bunch of linter errors after the config is resolved that will need to be sorted out in this PR. |
Collaborator
|
@bsavitzky these are my suggested changes for the linter |
| E266, | ||
| E303, | ||
| E402, | ||
| E501, |
Collaborator
There was a problem hiding this comment.
I think we should add, locally collects files differently to the GA
to make it ignore __init__.py and setup.py files and to stop it searching docs, when run locally, we can also add to tests it to ignore this as well
exclude =
*__init__.py
*setup.py
docs
bsavitzky
force-pushed
the
linter_actions_fix
branch
from
08240da to
fc82d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundancies and fix opaque naming conventions in linter actions