F811, F523/F524, F841, F741 - Corrections in crystal.py

[alex-rakowski]

F811, F523/F524, F841, F741 - Corrections

[alex-rakowski]

added the changes to linter.yaml, .flake8 and removed build-flake.yaml as the GA is in a strange state in dev at the moment, so the test would fail.

[sezelt]

The changes look good, you can delete those two unused variables in crystal.py and then I think this is ready to go.

[sezelt]

This does seem to overlap with #563 a bit, so maybe they should be combined? Probably the only potential conflict is if they make different changes to the flake8 file

[sezelt]

I'm approving this since all the changes it makes are acceptable, but I'll hold off on merging so that we can decide how to reconcile with #563

[bsavitzky]

See comment in-thread

[bsavitzky]

Hey @alex-rakowski -

This PR is redundant / in conflict with PR#563. All file lines changed here other than those in crystal.py have already been modified, often quite differently, in that PR. Can we sync up?

Ultimately this should be a single PR, otherwise we're just making more work for ourselves!

[sezelt]

I've merged this with #560