feat(tests): EIP-2780 warm/cold-aware top-frame delegation#3045
Draft
chfast wants to merge 12 commits into
Draft
feat(tests): EIP-2780 warm/cold-aware top-frame delegation#3045chfast wants to merge 12 commits into
chfast wants to merge 12 commits into
Conversation
…thereum#2972) Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com>
…reum#3019) Co-authored-by: marioevz <marioevz@gmail.com>
* feat(spec, specs): EIP-7997 - Spec and basic tests * feat(spec-specs): EIP 7997 - More tests * bugfix(specs): Add logic to add 0x12 as a special contract outside the precompile range * feat(tests): 7997 - add a check at the transition, adds tests for prewarming, CALLCODE, and giving it a balance via SELFDESTRUCT * fix: address PR feedback * feat(spec): Use Arachnid create2 contract * feat(specs, spec-test): Remove unneeded code * feat(spec-tests): Remove unneeded tests * feat(test-specs): Add sstore metadata for gas pricing * fix(test-specs): Remove sstore metadata * feat(test-specs): Add Arachnid contract to system contracts * feat(test-specs): Add a BAL test, large initcode test, and an ef prefix test * fix(test-specs): remove unneeded pre_alloc_mutable decorators * Add Amsterdam config to test_execute_eth_config * fix: Uses storage.store_next and mark valid_from EIP7997 instead of Amsterdam * fix: don't hardcode gas values, call_opcode parametrization * fix: Remove Factory predeploy from system contracts * fix: Remove explicit set of gas_limit * lint * Whitespace
…reum#2842) * feat: implement eip 8246 * tests: enhance eip 8246 coverage * refactor: resolve failing selfdestruct scenario * chore: fix linting issue * fix(specs): Remove all references to burn logs * fix(tests): Fix remaining tests * chore: rename function --------- Co-authored-by: marioevz <marioevz@gmail.com>
Assert that an EIP-7702 delegation target already made warm via the access list is resolved at the WARM_ACCESS rate at the top transaction frame, per the EIP-2780 Interactions note (the EIP-2929 accessed_addresses model). EIP-2780 is internally inconsistent here: its normative top-level gas-cost bullet and reference-cases table charge an unconditional COLD_ACCOUNT_ACCESS, whereas the Interactions note specifies warm/cold-aware accounting. This probe pins the Interactions-note reading; test_warmth_invariants.py pins the unconditional-cold one. Marked xfail(strict=True): the implementation currently charges cold unconditionally, so the probe is CI-green today and a strict XPASS forces the marker's removal once the spec is disambiguated in favor of warm/cold-aware accounting and EELS adopts it.
Contributor
|
The scenario is already covered in this test. If we decide to update the spec and the implementation, could we just adapt that test? |
Member
Author
Yes, we can. |
23 tasks
Member
|
Just converting to draft as this targets |
4 tasks
20 tasks
Contributor
|
Following ACDT should this be closed as we are going with ethereum/EIPs#11844 over ethereum/EIPs#11778? |
Member
Author
Maybe we should keep the test with modified expectations? Or is this already covered somewhere else? |
Contributor
SGTM! |
spencer-tb
force-pushed
the
devnets/glamsterdam/6
branch
from
4bc0fc6 to
d0338f5
Compare
spencer-tb
added
C-feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Assert that an EIP-7702 delegation target already made warm via the access list is resolved at the WARM_ACCESS rate at the top transaction frame, per the EIP-2780 Interactions note (the EIP-2929 accessed_addresses model).
EIP-2780 is internally inconsistent here: its normative top-level gas-cost bullet and reference-cases table charge an unconditional COLD_ACCOUNT_ACCESS, whereas the Interactions note specifies warm/cold-aware accounting. This probe pins the Interactions-note reading; test_warmth_invariants.py pins the unconditional-cold one.
Marked xfail(strict=True): the implementation currently charges cold unconditionally, so the probe is CI-green today and a strict XPASS forces the marker's removal once the spec is disambiguated in favor of warm/cold-aware accounting and EELS adopts it.
Here's the relevant discussion on Eth R&D for context.
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.