🤖 feat: show 'Compaction complete' in response notifications #1888
+40
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the 'notify on response' feature triggers for a post-compaction message, show 'Compaction complete' as the notification body instead of the compaction summary text (which can be long and technical). Changes: - Add isCompaction parameter to onResponseComplete callback - Capture isCompacting from stream context before cleanup - Handle compaction case in App.tsx notification logic
ammario
approved these changes
Jan 24, 2026
ammario
pushed a commit
that referenced
this pull request
Jan 24, 2026
## Summary Skip the compaction-complete notification when the compaction request includes a continue message by threading compaction metadata through the response-complete callback, avoiding racy queued-message checks. This is a follow-up to #1888. ## Implementation - Added compaction continue metadata to `StreamingMessageAggregator` stream context and pass it through `onResponseComplete` as an optional compaction object - Updated `WorkspaceStore` callback typing to accept the optional compaction object - Updated `App.tsx` to skip notifications when `compaction?.hasContinueMessage` and to use compaction presence for the "Compaction complete" body ## Validation - `make static-check` --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$1.61`_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=1.61 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the 'notify on response' feature triggers for a post-compaction message, show "Compaction complete" as the notification body instead of the compaction summary text.
Background
The compaction summary text can be long and technical, making it unsuitable for notification body content. Users just need to know compaction finished, not see the full summary.
Implementation
isCompactionparameter to theonResponseCompletecallback signature inStreamingMessageAggregatorwasCompactingfrom the stream context before cleanup (since cleanup removes the stream)WorkspaceStorecallback type to include the new parameterApp.tsxto show "Compaction complete" whenisCompactionis trueGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$1.08