🤖 fix: skip notification on compaction when continue is queued #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compaction completes with a continue message queued, the continue will trigger its own stream. Skip the 'Compaction complete' notification in this case since the assistant is still working - the notification will fire when the continue stream completes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skip the compaction-complete notification when the compaction request includes a continue message by threading compaction metadata through the response-complete callback, avoiding racy queued-message checks.
This is a follow-up to #1888.
Implementation
StreamingMessageAggregatorstream context and pass it throughonResponseCompleteas an optional compaction objectWorkspaceStorecallback typing to accept the optional compaction objectApp.tsxto skip notifications whencompaction?.hasContinueMessageand to use compaction presence for the "Compaction complete" bodyValidation
make static-checkGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$1.61