Skip to content

single query per node in UI picking backend #22049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ickshonpe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

single query per node in UI picking backend #22049

ickshonpe wants to merge 3 commits into from
+8 −11

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 6, 2025

Objective

The UI picking backend queries twice for the node data. Simplify ui_picking by storing the camera entity and picking data in hit_nodes instead of the second query.

Solution

Store the camera entity and picking data in hit_nodes instead of querying for them again.

@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Picking Pointing at and selecting objects of all sorts A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ickshonpe