-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
UI per text section picking #22047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 23 commits into
bevyengine:main
from
ickshonpe:text_section_picking
Dec 11, 2025
Merged
UI per text section picking #22047
alice-i-cecile
merged 23 commits into
bevyengine:main
from
ickshonpe:text_section_picking
Dec 11, 2025
+93
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inter is over a text node.
…it a second time. * Add the entity of the text section hit to `hit_nodes`. * When picked node is a text node and `require_markers` is enabled, check if the hit section entity is picked.
…The observers turn the section's color to white when the pointer hovers them.
viridia
approved these changes
Dec 9, 2025
Contributor
viridia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
ThierryBerger
approved these changes
Dec 10, 2025
alice-i-cecile
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Picking
Pointing at and selecting objects of all sorts
A-Text
Rendering and layout for characters
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Feature
A new feature, making something new possible
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
M-Migration-Guide
A breaking change to Bevy's public API that needs to be noted in a migration guide
M-Release-Note
Work that should be called out in the blog due to impact
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow picking text per section.
Fixes #17477
Solution
In
ui_pickingwhenever a node with text components is below a pointer, don't add theTextnode's entity to thehit_nodeslist. Instead, iterate the list of text section bounding rects in itsTextLayoutInfocomponent to find which text section the pointer is over, and add that section's entity id to thehit_nodeslist.NodeQuery.pick_ui_text. Finds if a text section is hovered and returns its id.hit_nodeswhen hovered.hit_nodes, instead of querying for it a second time.require_markersis enabled, check if the hit section entity has aPickablecomponent, instead of the text node.This design might need to be changed later to allow for text selection and copying. But there doesn't seem any need to overcomplicate things for now by considering it.
Testing
I added observers to the
TextBackgroundColorsexample's text entities. The observers turn a text section's text color to white when the pointer hovers them.