Generic hierarchy propagate #22043
Generic hierarchy propagate #22043
Conversation
| nodes: &NodeQuery<'_, '_, T>, | ||
| ) { | ||
| #[cfg(feature = "std")] | ||
| //let _span = bevy_log::info_span!("input propagation worker").entered(); |
There was a problem hiding this comment.
this is just commented out because bevy_log isn't a dependency of bevy_ecs. Not sure if it's necessary to have it. bevy_log::info_span is only called once in entire codebase.
molikto
force-pushed
the
generic-hierachy-2
branch
2 times, most recently
from
6d8860b to
fa31466
Compare
molikto
force-pushed
the
generic-hierachy-2
branch
from
9951aae to
b1084ec
Compare
fix ci more lint more lint fmt fix lint unused mark fix lint fix lint fix again fix compile again
molikto
force-pushed
the
generic-hierachy-2
branch
from
b1084ec to
cb43707
Compare
| hierarchy_propagate_simple::<Transform>, | ||
| hierarchy_propagate_complex::<Transform>, | ||
| ) | ||
| .chain(), |
There was a problem hiding this comment.
is it possible to write fn hierarchy_down_propagate_chain(): ? { } I don't know that type should this be. I think only this should be pub, the systems should be private
| /// Propagates data down the hierarchy from parent to children (like transforms, visibility). | ||
| pub trait DownPropagate { | ||
| /// The input component type that contains the local data to be propagated. | ||
| type Input: Component; |
There was a problem hiding this comment.
is it possible to have Input: Bundle so we have multiple input components? I don't think so, does this means we need to have DownPropagate2 etc.
alice-i-cecile
added
C-Feature
|
I'm fairly skeptical of adding more complexity here, especially since we already added a simpler generic inheritance system in #17575. The transform propagation code is extremely perf sensitive, and I don't want it accidentally getting tweaked to improve things for other generic users. |
2 participants
Objective
DownPropagate. Can be reused in other places.DownPropagateAll changes are very mechanical and I tried to not do any refactors that changes any logic. Easier to review by individual commits.
Solution
Testing