Skip to content

Conversation

@guittari
Copy link
Contributor

@guittari guittari commented Dec 11, 2025

Summary of changes (edited: 12/16/2025):

  • Changed several project fields (emberdandisets, restricted_datasets, vault_ids, and related_*) to be multivalued lists so they accept [] instead of being treated as single strings
  • Added a DOI pattern to ember_doi to enforce basic DOI formatting
  • Added a Funding class and a corresponding funding field on EmberProject to capture grant information in a consistent way
  • Added a Contributor class and updated data_administrator to use an inlined Contributor object rather than a free-text string
  • These changes align the schema with how the project YAMLs are already structured and avoid validation issues caused by list-like fields being interpreted as strings

@candleindark candleindark marked this pull request as ready for review December 11, 2025 19:02
@candleindark candleindark marked this pull request as draft December 11, 2025 19:02
Copy link
Contributor

@candleindark candleindark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.

The other question I have is how this model relates to the table in https://github.com/aplbrain/BBQS-EMBER-Data-Model/tree/adding-to-emberset-refactor/EMBER_Metadata#emberproject.

@guittari guittari marked this pull request as ready for review December 16, 2025 23:25
Copy link
Contributor

@erikjohnson24 erikjohnson24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thoughts on DOI but looking great!

interactions in animal models in order to understand their influence on vulnerability
to drug addiction.

ember_doi: "10.00000/EMBER.R21DA048634"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this DOI exist? if not I would leave as an empty string for now. I can't get it to resolve to anything right now. We can add later when one actually exists?

@@ -0,0 +1,45 @@
### Getting Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a quick section ### EMBER Project Metadata which describes the purpose of this repo in 2-3 sentences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants