-
Notifications
You must be signed in to change notification settings - Fork 1
Creating a data.yaml for each project #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
candleindark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments.
The other question I have is how this model relates to the table in https://github.com/aplbrain/BBQS-EMBER-Data-Model/tree/adding-to-emberset-refactor/EMBER_Metadata#emberproject.
…nding and Contributor objects, and updated the schema to validate per-project data.yaml files cleanly
erikjohnson24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thoughts on DOI but looking great!
| interactions in animal models in order to understand their influence on vulnerability | ||
| to drug addiction. | ||
|
|
||
| ember_doi: "10.00000/EMBER.R21DA048634" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this DOI exist? if not I would leave as an empty string for now. I can't get it to resolve to anything right now. We can add later when one actually exists?
| @@ -0,0 +1,45 @@ | |||
| ### Getting Started | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a quick section ### EMBER Project Metadata which describes the purpose of this repo in 2-3 sentences?
Summary of changes (edited: 12/16/2025):
emberdandisets,restricted_datasets,vault_ids, andrelated_*) to be multivalued lists so they accept [] instead of being treated as single stringsember_doito enforce basic DOI formattingFundingclass and a corresponding funding field onEmberProjectto capture grant information in a consistent wayContributorclass and updateddata_administratorto use an inlinedContributorobject rather than a free-text string