[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101

dididy · 2025-10-11T14:47:24Z

What is this PR for?

Addition and improvement of notebook-related E2E tests for New UI

/#/notebook/:noteId – View or edit a specific notebook
/#/notebook/:noteId/revision/:revisionId – View a specific revision of a notebook
/#/notebook/:noteId/paragraph/:paragraphId – Notebook paragraph presentation mode

PAGES.WORKSPACE.NOTEBOOK
→ src/app/pages/workspace/notebook/notebook.component

PAGES.WORKSPACE.NOTEBOOK_ACTION_BAR
→ src/app/pages/workspace/notebook/action-bar/action-bar.component

PAGES.WORKSPACE.NOTEBOOK_PARAGRAPH
→ src/app/pages/workspace/notebook/paragraph/paragraph.component

PAGES.WORKSPACE.NOTEBOOK_SIDEBAR
→ src/app/pages/workspace/notebook/sidebar/sidebar.component

PAGES.WORKSPACE.PUBLISHED_PARAGRAPH
→ src/app/pages/workspace/published/paragraph/paragraph.component

What type of PR is it?

Improvement

Todos

What is the Jira issue?

ZEPPELIN-6358

How should this be tested?

Screenshots (if appropriate)

Questions:

Does the license files need to update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

tbonelee · 2025-10-26T08:17:30Z

Could you rebase this onto master branch?

tbonelee

Could you take a quick pass on two areas?

There are places where try/catch accepts both error and non-error paths. Could we make these more explicit, either intentionally silencing with a clear rationale or failing, so we reduce false positives?
For browser-specific branches (e.g., notebook-keyboard-page.ts → executePlatformShortcut), could we extract that logic so the main flow reads sequentially and the differences are isolated?

zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts

zeppelin-web-angular/e2e/models/notebook-keyboard-page.ts

zeppelin-web-angular/e2e/global-teardown.ts

zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts

dididy · 2025-10-27T16:53:40Z

You can see that request item 1 has been addressed in e92d5ae and item 2 in eea335a. Thank you for the thorough review.

dididy · 2025-12-22T13:34:41Z

It took some time to incorporate the review feedback, do incremental refactoring, and clean up the tests that were failing in CI.
I’ve opened #5128 with the common environment and utility changes. Once that PR is merged, I’ll follow up with the PRs below:

A PR reflecting changes to existing test POMs, utils, and specs
A PR for keyboard shortcut–related tests
A PR for the remaining notebook-related tests
A PR for tests related to shared modules (folder-rename, note-rename, note-toc)

Once all of those PRs are merged, we can close the current PR accordingly.

…5101 ### What is this PR for? In #5101, the amount of changes became too large, and a committer suggested splitting it into smaller parts. Since the updates related to the common test environment and shared utility functions have already proven to be stable, I separated those pieces into this dedicated PR. This PR includes only the **safe, standalone changes** that improve the shared E2E environment and utilities. #### [Summary of Changes] * **Refined and separated E2E test environment setup** * Improved global setup/teardown * CI: using ZEPPELIN_E2E_TEST_NOTEBOOK_DIR * To use `ZEPPELIN_E2E_TEST_NOTEBOOK_DIR` locally, the server has to be restarted at least once, which feels a bit odd to enforce during E2E test execution. To make things less messy from a UI perspective, I reorganized the structure so that all tests are collected under `E2E_TEST_FOLDER` instead. * Added folder/notebook initialization and cleanup logic * you can run it standalone with this command:`npm run e2e:cleanup`(automatically run this once the tests are finished) * **Extracted shared utilities and constants** * Added common E2E constant (e.g., `E2E_TEST_FOLDER`) * Introduced cleanup utilities to ensure stable post-test state * **Updated GitHub Actions (`frontend.yml`)** * Added environment variables(for python interpreter), notebook repo initialization, and cleanup steps * Due to potential storage and cost concerns, I shortened the retention period for the `Playwright report` from 30 days to 3 days * **Updated Playwright / ESLint configurations** * ts to cjs ### What type of PR is it? Improvement Refactoring ### Todos ### What is the Jira issue? ZEPPELIN-6358 ### How should this be tested? ```sh cd zeppelin-web-angular nvm use npm run start npm run e2e npm run e2e:cleanup ``` ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5128 from dididy/e2e/notebook-base. Signed-off-by: ChanHo Lee <[email protected]>

…5101 ### What is this PR for? In #5101, the amount of changes became too large, and a committer suggested splitting it into smaller parts. Since the updates related to the common test environment and shared utility functions have already proven to be stable, I separated those pieces into this dedicated PR. This PR includes only the **safe, standalone changes** that improve the shared E2E environment and utilities. #### [Summary of Changes] * **Refined and separated E2E test environment setup** * Improved global setup/teardown * CI: using ZEPPELIN_E2E_TEST_NOTEBOOK_DIR * To use `ZEPPELIN_E2E_TEST_NOTEBOOK_DIR` locally, the server has to be restarted at least once, which feels a bit odd to enforce during E2E test execution. To make things less messy from a UI perspective, I reorganized the structure so that all tests are collected under `E2E_TEST_FOLDER` instead. * Added folder/notebook initialization and cleanup logic * you can run it standalone with this command:`npm run e2e:cleanup`(automatically run this once the tests are finished) * **Extracted shared utilities and constants** * Added common E2E constant (e.g., `E2E_TEST_FOLDER`) * Introduced cleanup utilities to ensure stable post-test state * **Updated GitHub Actions (`frontend.yml`)** * Added environment variables(for python interpreter), notebook repo initialization, and cleanup steps * Due to potential storage and cost concerns, I shortened the retention period for the `Playwright report` from 30 days to 3 days * **Updated Playwright / ESLint configurations** * ts to cjs ### What type of PR is it? Improvement Refactoring ### Todos ### What is the Jira issue? ZEPPELIN-6358 ### How should this be tested? ```sh cd zeppelin-web-angular nvm use npm run start npm run e2e npm run e2e:cleanup ``` ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5128 from dididy/e2e/notebook-base. Signed-off-by: ChanHo Lee <[email protected]> (cherry picked from commit a041703) Signed-off-by: ChanHo Lee <[email protected]>

dididy force-pushed the e2e/notebook branch 8 times, most recently from d6228ac to b07b933 Compare October 19, 2025 05:34

dididy force-pushed the e2e/notebook branch from b81dda2 to ceb2140 Compare October 24, 2025 11:50

dididy mentioned this pull request Oct 25, 2025

[ZEPPELIN-6349] Bump Angular from 9 to 13 #5109

Merged

5 tasks

tbonelee requested changes Oct 26, 2025

View reviewed changes

dididy force-pushed the e2e/notebook branch 4 times, most recently from d058c16 to 9bd2f40 Compare October 27, 2025 10:13

dididy force-pushed the e2e/notebook branch 13 times, most recently from 1dc6ffa to f4f51b1 Compare October 30, 2025 15:57

dididy added 2 commits December 20, 2025 09:16

apply review

8c3dab5

remove unused code

6010891

dididy force-pushed the e2e/notebook branch 8 times, most recently from 50eed38 to 07b58b4 Compare December 21, 2025 13:08

dididy added a commit to dididy/zeppelin that referenced this pull request Dec 21, 2025

Seperate environment config and shared utilities from apache#5101

c34a66b

dididy added a commit to dididy/zeppelin that referenced this pull request Dec 21, 2025

Seperate environment config and shared utilities from apache#5101

076b861

dididy added a commit to dididy/zeppelin that referenced this pull request Dec 21, 2025

Seperate environment config and shared utilities from apache#5101

d163e5e

dididy added a commit to dididy/zeppelin that referenced this pull request Dec 21, 2025

Seperate environment config and shared utilities from apache#5101

68e804c

dididy force-pushed the e2e/notebook branch 3 times, most recently from f069171 to 1d263ec Compare December 22, 2025 03:12

dididy added a commit to dididy/zeppelin that referenced this pull request Dec 22, 2025

Seperate environment config and shared utilities from apache#5101

451297b

dididy force-pushed the e2e/notebook branch 2 times, most recently from ba47403 to 3f5582c Compare December 22, 2025 11:41

refactoring tests

450cb9c

dididy force-pushed the e2e/notebook branch from 3f5582c to 450cb9c Compare December 22, 2025 13:33

dididy force-pushed the e2e/notebook branch 2 times, most recently from 375098e to 4993ecd Compare December 23, 2025 00:00

fix broken test

0c97624

dididy force-pushed the e2e/notebook branch from 4993ecd to 0c97624 Compare December 23, 2025 03:11

revert unproper change for selenium ci step

29c9a2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101

[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101

Uh oh!

dididy commented Oct 11, 2025

Uh oh!

tbonelee commented Oct 26, 2025

Uh oh!

tbonelee left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dididy commented Oct 27, 2025

Uh oh!

dididy commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101

Are you sure you want to change the base?

[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101

Uh oh!

Conversation

dididy commented Oct 11, 2025

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

tbonelee commented Oct 26, 2025

Uh oh!

tbonelee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dididy commented Oct 27, 2025

Uh oh!

dididy commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants