fix broken tests

Author: dididy

zeppelin-web-angular/e2e/models/home-page.ts

@@ -69,7 +69,7 @@ export class HomePage extends BasePage {
     this.notebookSection = page.locator('text=Notebook').first();
     this.helpSection = page.locator('text=Help').first();
     this.communitySection = page.locator('text=Community').first();
-    this.createNewNoteButton = page.locator('zeppelin-node-list a').filter({ hasText: 'Create new Note' });
+    this.createNewNoteButton = page.getByText('Create new Note', { exact: true }).first();
     this.importNoteButton = page.locator('text=Import Note');
     this.searchInput = page.locator('textbox', { hasText: 'Search' });
     this.filterInput = page.locator('input[placeholder*="Filter"]');

zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts

@@ -66,8 +66,13 @@ export class NotebookActionBarUtil {
 
     const initialCodeVisibility = await this.actionBarPage.isCodeVisible();
     await this.actionBarPage.toggleCodeVisibility();
-    const newCodeVisibility = await this.actionBarPage.isCodeVisible();
 
+    // Wait for the icon to change by checking for the expected icon
+    const expectedIcon = initialCodeVisibility ? 'fullscreen' : 'fullscreen-exit';
+    const icon = this.actionBarPage.showHideCodeButton.locator('i[nz-icon] svg');
+    await expect(icon).toHaveAttribute('data-icon', expectedIcon, { timeout: 5000 });
+
+    const newCodeVisibility = await this.actionBarPage.isCodeVisible();
     expect(newCodeVisibility).toBe(!initialCodeVisibility);
 
     // Verify the button is still functional after click
@@ -80,8 +85,13 @@ export class NotebookActionBarUtil {
 
     const initialOutputVisibility = await this.actionBarPage.isOutputVisible();
     await this.actionBarPage.toggleOutputVisibility();
-    const newOutputVisibility = await this.actionBarPage.isOutputVisible();
 
+    // Wait for the icon to change by checking for the expected icon
+    const expectedIcon = initialOutputVisibility ? 'book' : 'read';
+    const icon = this.actionBarPage.showHideOutputButton.locator('i[nz-icon] svg');
+    await expect(icon).toHaveAttribute('data-icon', expectedIcon, { timeout: 5000 });
+
+    const newOutputVisibility = await this.actionBarPage.isOutputVisible();
     expect(newOutputVisibility).toBe(!initialOutputVisibility);
 
     // Verify the button is still functional after click

zeppelin-web-angular/e2e/models/notebook.util.ts

@@ -60,7 +60,9 @@ export class NotebookUtil extends BasePage {
 
       // Wait for the notebook to be created and navigate to it with enhanced error handling
       try {
-        await this.page.waitForURL(url => url.toString().includes('/notebook/'), { timeout: 60000 });
+        await this.page.waitForURL(url => url.toString().includes('/notebook/'), { timeout: 90000 });
+        const notebookTitleLocator = this.page.locator('.notebook-title-editor');
+        await expect(notebookTitleLocator).toHaveText(notebookName, { timeout: 15000 });
       } catch (urlError) {
         console.warn('URL change timeout, checking current URL:', this.page.url());
         // If URL didn't change as expected, check if we're already on a notebook page