Skip to content

521: Fix Value Representation for References #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BirgitBoss merged 3 commits into from
Jun 29, 2026
Merged

521: Fix Value Representation for References #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b953fe2
replacing referencevalue with reference
sebbader-sap Jun 26, 2026
956c6e9
replacing referencevalue with reference
sebbader-sap Jun 26, 2026
d40c1a9
Merge branch 'SeBa/fix-reference-value' of https://github.com/admin-s…
sebbader-sap Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions Part2-API-Schemas/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ components:
AnnotatedRelationshipElementValue:
properties:
first:
$ref: "#/components/schemas/ReferenceValue"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
second:
$ref: "#/components/schemas/ReferenceValue"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
annotations:
$ref: "#/components/schemas/ValueOnly"
type: object
Expand Down Expand Up @@ -244,7 +244,7 @@ components:
BasicEventElementValue:
properties:
observed:
$ref: "#/components/schemas/ReferenceValue"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
required:
- observed
type: object
Expand Down Expand Up @@ -920,25 +920,16 @@ components:
allOf:
- $ref: "#/components/schemas/SubmodelElementAttributes"
ReferenceElementValue:
$ref: "#/components/schemas/ReferenceValue"
ReferenceValue:
type: object
properties:
type:
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/ReferenceTypes"
keys:
type: array
items:
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Key"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
RelationshipElementMetadata:
allOf:
- $ref: "#/components/schemas/SubmodelElementAttributes"
RelationshipElementValue:
properties:
first:
$ref: "#/components/schemas/ReferenceValue"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
second:
$ref: "#/components/schemas/ReferenceValue"
$ref: "https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.2#/components/schemas/Reference"
type: object
Result:
properties:
Expand Down
1 change: 1 addition & 0 deletions documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@
* fix: Aligned date/time extraction functions (`$dayOfWeek`, `$dayOfMonth`, `$month`, `$year`) in JSON Schema to accept all `dateTimeOperand` types per BNF grammar, and widened `timeLiteralPattern` to support fractional seconds.
* fix: Harmonized `SecurityQueryFilter` between API and Security specifications and added missing `FILTERLIST` construct to the BNF grammar and JSON Schema.
* fix: Changed JSON Schema validation from `oneOf` to `anyOf` where BNF grammar allows mixed inline and named groups in concatenation scenarios.
* Updated the response contract of `PostAllAssetLinksById` in Discovery OpenAPI files by removing status code `404` for `POST /lookup/shells/{aasIdentifier}` to align with create-or-replace semantics. (https://github.com/admin-shell-io/aas-specs-api/issues/595[#595])

Check warning on line 24 in documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc

View workflow job for this annotation

GitHub Actions / qodana

Attribute not defined within project 

Attribute should be defined
* Updated the response contract of `PostAllAssetLinksById` in Discovery OpenAPI files by removing status code `409` for `POST /lookup/shells/{aasIdentifier}` to align with replace/update behavior on repeated payloads. (https://github.com/admin-shell-io/aas-specs-api/issues/596[#596])

Check warning on line 25 in documentation/IDTA-01002-3/modules/ROOT/pages/changelog.adoc

View workflow job for this annotation

GitHub Actions / qodana

Attribute not defined within project 

Attribute should be defined
* Updated the response contract of `GetAllSubmodelDescriptors` in Submodel Registry OpenAPI files by removing status code `404` for `GET /submodel-descriptors`, so an empty collection is consistently represented by `200` with an empty result. (https://github.com/admin-shell-io/aas-specs-api/issues/597[#597])
* Submodel Service Specification – Read Profile had the wrong identifier `https://admin-shell.io/aas/API/3/1/AssetAdministrationShellServiceSpecification/SSP-002` instead of https://admin-shell.io/aas/API/3/1/SubmodelServiceSpecification/SSP-002`
* fix: Aligned `idShort` pattern in BNF grammar and JSON Schema with Metamodel Constraint AASd-002 to correctly enforce minimum two characters and prevent trailing hyphens.
* fix: Replaced OpenAPI references to `ReferenceValue` with `Reference` to align with the specification text. (https://github.com/admin-shell-io/aas-specs-api/issues/521[#521])



Expand Down
Loading