Skip to content

fix(agentgateway): remove telemetry source attribution from _lob.py #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiagoek wants to merge 2 commits into from
+3 −11
Closed

fix(agentgateway): remove telemetry source attribution from _lob.py #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7d5bef
fix(agentgateway): remove telemetry source attribution from _lob.py
tiagoek Jul 15, 2026
93ff663
chore: bump version to 0.35.1
tiagoek Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "sap-cloud-sdk"
version = "0.35.0"
version = "0.35.1"
description = "SAP Cloud SDK for Python"
readme = "README.md"
license = "Apache-2.0"
Expand Down
12 changes: 2 additions & 10 deletions src/sap_cloud_sdk/agentgateway/_lob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
ConsumptionLevel,
ConsumptionOptions,
)
from sap_cloud_sdk.core.telemetry import Module

from sap_cloud_sdk.agentgateway._fragments import (
LABEL_KEY,
FragmentLabel,
Expand Down Expand Up @@ -89,10 +87,7 @@ def _fetch_auth_token(
Raises:
MCPServerNotFoundError: If no auth token is returned.
"""
client = create_destination_client(
instance=_DESTINATION_INSTANCE,
_telemetry_source=Module.AGENTGATEWAY,
)
client = create_destination_client(instance=_DESTINATION_INSTANCE)

@NicoleMGomes NicoleMGomes Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry will still be generated, just not with the correct source, isn't it? Why is this a problem?

dest = client.get_destination(
dest_name,
level=ConsumptionLevel.PROVIDER_SUBACCOUNT,
Expand Down Expand Up @@ -134,10 +129,7 @@ def get_ias_client_id_lob() -> str:
Any exception raised by the destination client.
"""
dest_name = _ias_dest_name()
client = create_destination_client(
instance=_DESTINATION_INSTANCE,
_telemetry_source=Module.AGENTGATEWAY,
)
client = create_destination_client(instance=_DESTINATION_INSTANCE)
dest = client.get_destination(
dest_name,
level=ConsumptionLevel.PROVIDER_SUBACCOUNT,
Expand Down
Loading