fix(agentgateway): remove telemetry source attribution from _lob.py#229
Closed
tiagoek wants to merge 2 commits into
Closed
fix(agentgateway): remove telemetry source attribution from _lob.py#229tiagoek wants to merge 2 commits into
tiagoek wants to merge 2 commits into
Conversation
Remove _telemetry_source=Module.AGENTGATEWAY from create_destination_client calls in _fetch_auth_token and get_ias_client_id_lob, and drop the now-unused Module import.
NicoleMGomes
approved these changes
Jul 15, 2026
| instance=_DESTINATION_INSTANCE, | ||
| _telemetry_source=Module.AGENTGATEWAY, | ||
| ) | ||
| client = create_destination_client(instance=_DESTINATION_INSTANCE) |
Contributor
There was a problem hiding this comment.
telemetry will still be generated, just not with the correct source, isn't it? Why is this a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requested by @smahr — removes
_telemetry_source=Module.AGENTGATEWAYfrom the twocreate_destination_client()calls in_lob.pyso that internal auth/IAS resolution steps do not appear asAGENTGATEWAY → DESTINATIONcross-module metrics.Changes:
_telemetry_source=Module.AGENTGATEWAYfrom_fetch_auth_tokenandget_ias_client_id_lobfrom sap_cloud_sdk.core.telemetry import Moduleimport0.35.1Scope: intentionally limited to
_lob.py._fragments.pyretains the attribution.Test plan
_fetch_auth_tokenstill resolves auth tokens correctlyget_ias_client_id_lobstill returns the client ID correctly