[oneshot] SS-49 Add validation for NOT NULL columns to COPY FROM query planning #34862
+40
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
NOT NULLcolumn in the destination table does not have a default, and is not specified to be copied into by theCOPY FROMstatement, materialize will panic at the time of Row encoding, which is very undesirable behavior. By checking at query planning time, we can reject theCOPY FROMstatement early on with a descriptive error message.Motivation
https://github.com/MaterializeInc/database-issues/issues/9886
Tips for reviewer
I did use Claude to write this, but I double checked everything and it seems reasonable and correct. My only concern is if this is the right location to be performing this check.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.