[oneshot][s3] SS-50 Add cases to COPY FROM s3 testdrive #34849
Merged
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just add some of the test cases that @martykulma created in an old branch to
test/testdrive/copy-from-s3-minio.td, to be expanded on in stacked PRs.Motivation
SS-50: testdrive test
Tips for reviewer
No code changes, only added cases to check in
.tdfile. The commented out case fort1_not_nullis address in a followup PR.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.