Skip to content

Conversation

@patrickwwbutler
Copy link
Contributor

@patrickwwbutler patrickwwbutler commented Jan 28, 2026

This just add some of the test cases that @martykulma created in an old branch to test/testdrive/copy-from-s3-minio.td, to be expanded on in stacked PRs.

Motivation

SS-50: testdrive test

Tips for reviewer

No code changes, only added cases to check in .td file. The commented out case for t1_not_null is address in a followup PR.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@patrickwwbutler patrickwwbutler force-pushed the patrick/copy-from-s3-tests branch 2 times, most recently from 4157231 to 9d277d1 Compare January 29, 2026 16:49
@patrickwwbutler patrickwwbutler changed the title Patrick/copy from s3 tests [oneshot][s3] Add cases to COPY FROM s3 testdrive Jan 29, 2026
@patrickwwbutler patrickwwbutler requested review from a team, DAlperin, martykulma and ublubu January 29, 2026 16:56
! COPY INTO t1_single_col FROM '${1_csv_url}' (FORMAT CSV);
contains:wrong number of columns

# disabled as MZ panics database-issues#9886
Copy link
Contributor Author

@patrickwwbutler patrickwwbutler Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is enabled in a followup: #34862

@patrickwwbutler patrickwwbutler marked this pull request as ready for review January 29, 2026 17:16
@patrickwwbutler patrickwwbutler changed the title [oneshot][s3] Add cases to COPY FROM s3 testdrive [oneshot][s3] SS-50 Add cases to COPY FROM s3 testdrive Jan 29, 2026
Copy link
Member

@DAlperin DAlperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@patrickwwbutler patrickwwbutler merged commit d008d49 into MaterializeInc:main Jan 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants