add a teos-10 version of frazil formation+melt#462
Draft
alicebarthel wants to merge 11 commits into
Draft
Conversation
Author
|
@njeffery the key simplification that I have left in at this stage is that formation/melt is calculated based on the per-layer characteristics (i.e. would this layer freeze? --> adds to the frazil formed). The better way that we agreed to try is to mix the frazil (energy, mass, salt) first before assessing whether the layer would freeze. |
8615be8 to
d85d5d7
Compare
Author
|
@njeffery, thanks for your feedback! I updated the code accordingly: massLimit on melt tendency, and refactoring the melt terms using a common factor |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is to provide a space to review/discuss the implementation of a new frazil code.
The frazil is meant to be thermodynamically consistent with the teos-10 ocean in omega.
We calculate the (cell, layer) tendencies and store 3 column-accumulated frazil fields that will be passed to the coupler.
For conservation, we keep track of pure (fresh) ice mass, brine water mass, and brine salt mass separately within the ocean to allow melt to be energetically-consistent.
I added a vertical conservation check and a vertical depth limit.
The tests currently rely on a verbose log that only work on CPU. This will be removed before merge/production.
The eos functions rely on the module, which require CPU. Later port of eos features will allow portability.
I haven't gotten to type up a clean omega frazil documentation yet, but the existing overleaf should be roughly in line with this implementation. Happy to discuss.
Checklist
pm-cpuhas passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build