adds an mpaso-like frazil option#466
Draft
alicebarthel wants to merge 12 commits into
Draft
Conversation
incl flux hijack and surface salt redistribution (manual toggle)
alicebarthel
commented
Jul 10, 2026
Comment on lines
+378
to
+382
| LocAccMIce(ICell) = LocAccMIce(ICell) * RhoSw; | ||
| LocAccMLiq(ICell) = LocAccMLiq(ICell) * RhoSw; | ||
| LocAccMSalt(ICell) = LocAccMSalt(ICell) * RhoSw * PPt2Salt; | ||
| LocAccELiq(ICell) = LocAccELiq(ICell) * RhoSw; | ||
| LocAccEIce(ICell) = LocAccEIce(ICell) * RhoSw; |
Author
There was a problem hiding this comment.
@andrewdnolan Let's chat about these terms so that we agree on the definitions and conversions for the SfcCoupling class.
alicebarthel
commented
Jul 10, 2026
Comment on lines
+489
to
+494
| // Convert to coupler units | ||
| LocAccMIce(ICell) = LocAccMIce(ICell) * RhoSw; | ||
| LocAccMLiq(ICell) = LocAccMLiq(ICell) * RhoSw; | ||
| LocAccMSalt(ICell) = LocAccMSalt(ICell) * RhoSw * PPt2Salt; | ||
| LocAccELiq(ICell) = LocAccELiq(ICell) * RhoSw; | ||
| LocAccEIce(ICell) = LocAccEIce(ICell) * RhoSw; |
Author
There was a problem hiding this comment.
@andrewdnolan Let's chat about these terms so that we agree on the definitions and conversions for the SfcCoupling class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is simply to increase the visibility of my basic-frazil dev branch (rebased on #462) to open it up for feedback.
In short:
pm-cpuandpm-gpuso could be an option while we wait for the eos port that will enable the teos frazil option to run on gpus.Caveats about physics:
IceRefSaland is conservative in salt (and mass). There is a manual option to use porosity rather than constantIceRefSal. The simple ctest shows that this is very non-conservative in salt (order of magnitude difference!). Thus the redistribution of the excess salt in the top layer reconciles this but is likely a strong surface forcing. I don't recommend this as a good approach either but we could later quantify this in single-column tests with more realistic conditions.Scope and future work:
To do:
Checklist
basicoption only) pass onpm-cpuandpm-gpu.has passed, using the Polaris
e3sm_submodules/Omegabaseline