chore: add script to fix activityRelations with wrong memberId #3686

skwowet · 2025-12-10T10:25:36Z

Note

Adds a Temporal workflow and CLI to detect activityRelations with wrong memberId and move them to the verified member by username per platform.

Script Executor Worker:
- New Temporal workflow workflows/fix-activityRelations-memberId to batch-fix activityRelations with incorrect memberId across all PlatformType values.
- Activities: add findMembersWithWrongActivityRelations, findMemberIdByUsernameAndPlatform, and moveActivityRelations wired into activities.ts.
- CLI script src/bin/fix-activityRelations-memberId.ts for cursor-based scanning of verified username identities and moving relations; added npm script fix-activity-relations-memberId.
- Types: add IFixActivityRelationsMemberIdArgs for batch/test-run control and platform iteration.
Data Access Layer:
- MemberRepository: add findMembersWithIncorrectActivityRelations and getMemberIdByUsernameAndPlatform queries.
- Use moveActivityRelationsWithIdentityToAnotherMember via writer connection to transfer relations.

^{Written by Cursor Bugbot for commit b8b732e. This will update automatically on new commits. Configure here.}

Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Joana Maia <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: emlimlf <[email protected]> Co-authored-by: joanagmaia <[email protected]>

… relations handling

…code

github-actions · 2025-12-12T07:36:51Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2025-12-12T07:37:02Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

cursor

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

services/apps/script_executor_worker/src/bin/fix-activity-relations-memberId.ts

github-actions · 2025-12-12T11:43:47Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

…ment and platform iteration

github-actions · 2025-12-12T13:08:33Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts

github-actions · 2025-12-12T13:19:26Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2025-12-12T13:20:54Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

cursor · 2025-12-12T13:32:08Z

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts

+          correctMemberId,
+          record.username,
+          record.platform,
+        )


Bug: Missing guard causes infinite loop when IDs match

The workflow calls moveActivityRelations(record.memberId, correctMemberId, ...) without checking if record.memberId === correctMemberId. Due to a race condition where data changes between the two queries (findMembersWithIncorrectActivityRelations and findMemberIdByUsernameAndPlatform), these values could be equal. When fromId === toId, the underlying moveActivityRelationsWithIdentityToAnotherMember function enters an infinite loop because the UPDATE doesn't change the memberId value, so the subquery keeps matching the same rows indefinitely. This would waste resources until Temporal's 30-minute activity timeout triggers.

github-actions · 2025-12-12T18:20:28Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

cursor · 2025-12-12T18:23:29Z

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts

+          record.username,
+          record.platform,
+        )
+      }),


Bug: Test-run mode still executes database writes in workflow

When args.testRun is true, the code logs the intended operation but then still calls moveActivityRelations because it's placed outside the if block. The bin script version correctly uses an if-else pattern to skip the write during test runs, but the workflow version logs the message and then unconditionally executes the write operation anyway. This defeats the purpose of the test-run flag and could cause unintended data modifications.

services/apps/script_executor_worker/src/bin/fix-activityRelations-memberId.ts

github-actions · 2025-12-12T18:37:15Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2025-12-15T14:54:18Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

cursor · 2025-12-15T15:03:16Z

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts

+          record.platform,
+        )
+      }),
+    )


Bug: Workflow doesn't comprehensively fix objectMemberId issues

The workflow queries only for memberId inconsistencies using findMembersWithIncorrectActivityRelations, but moveActivityRelationsWithIdentityToAnotherMember also attempts to fix objectMemberId. The objectMemberId update uses fromId (the wrong memberId) as the filter, so it only fixes objectMemberId when it coincidentally equals the wrong memberId value. The bin script correctly handles this with separate queries for both memberId and objectMemberId issues, but the workflow is missing the objectMemberId query loop, leaving many objectMemberId fixes incomplete.

Additional Locations (1)

services/libs/data-access-layer/src/old/apps/script_executor_worker/member.repo.ts#L387-L409

github-actions · 2025-12-17T09:43:19Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

services/apps/script_executor_worker/src/bin/fix-activityRelations-memberId.ts

github-actions · 2025-12-17T18:20:56Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

chore: add script to fix activityRelations with wrong memberId

4434ffb

skwowet self-assigned this Dec 10, 2025

skwowet and others added 4 commits December 10, 2025 15:55

Merge branch 'main' into script/fix-activityRelations-memberId

0b58663

Merge branch 'main' into script/fix-activityRelations-memberId

f3a0d75

Merge branch 'main' into script/fix-activityRelations-memberId

9f15ecb

skwowet marked this pull request as ready for review December 11, 2025 08:07

skwowet added 5 commits December 11, 2025 15:06

fix: improve error logging and conditional console output in activity…

76208af

… relations handling

fix: dedup activity relations by memberId, username, and platform in …

c494da2

…code

refactor: rename func to trigger temporal rebuild

c75e2fb

chore: test with normal script instead of temporal workflow for perf

99f3c54

refactor: separate read and write connections

6fc1886

cursor bot reviewed Dec 12, 2025

View reviewed changes

services/apps/script_executor_worker/src/bin/fix-activity-relations-memberId.ts Outdated Show resolved Hide resolved

refactor: rename and update findMembersWithWrongActivityRelatin

c42d842

fix: improve fixActivityRelationsMemberId workflow with buffer manage…

6564992

…ment and platform iteration

cursor bot reviewed Dec 12, 2025

View reviewed changes

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts Outdated Show resolved Hide resolved

refactor: streamline fixActivityRelationsMemberId workflow

02b87bb

skwowet force-pushed the script/fix-activityRelations-memberId branch from 86e3ae6 to 02b87bb Compare December 12, 2025 13:20

cursor bot reviewed Dec 12, 2025

View reviewed changes

chore: process by identities instead of relations to speed up

be59679

cursor bot reviewed Dec 12, 2025

View reviewed changes

feat: track total fixed memberIds in fixActivityRelationsMemberId script

42fa067

skwowet added 2 commits December 14, 2025 16:53

feat: add functionality to fix incorrect objectMemberIds

13a68d9

Merge branch 'main' into script/fix-activityRelations-memberId

534603a

cursor bot reviewed Dec 15, 2025

View reviewed changes

Merge branch 'main' into script/fix-activityRelations-memberId

4a780db

cursor bot reviewed Dec 17, 2025

View reviewed changes

services/apps/script_executor_worker/src/bin/fix-activityRelations-memberId.ts Show resolved Hide resolved

services/apps/script_executor_worker/src/bin/fix-activityRelations-memberId.ts Show resolved Hide resolved

Merge branch 'main' into script/fix-activityRelations-memberId

b8b732e

chore: add script to fix activityRelations with wrong memberId #3686

Are you sure you want to change the base?

chore: add script to fix activityRelations with wrong memberId #3686

Conversation

skwowet commented Dec 10, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

cursor bot Dec 12, 2025

Choose a reason for hiding this comment

Bug: Missing guard causes infinite loop when IDs match

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

cursor bot Dec 12, 2025

Choose a reason for hiding this comment

Bug: Test-run mode still executes database writes in workflow

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

cursor bot Dec 15, 2025

Choose a reason for hiding this comment

Bug: Workflow doesn't comprehensively fix objectMemberId issues

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

skwowet commented Dec 10, 2025 •

edited by cursor bot

Loading