refactor: streamline fixActivityRelationsMemberId workflow

Author: skwowet

services/apps/script_executor_worker/package.json

@@ -7,7 +7,6 @@
     "dev:local": "nodemon --watch src --watch ../../libs --ext ts --exec pnpm run start:debug:local",
     "dev": "nodemon --watch src --watch ../../libs --ext ts --exec pnpm run start:debug",
     "cleanup-fork-activities": "npx tsx src/bin/cleanup-fork-activities-and-maintainers.ts",
-    "fix-activity-relations-memberId": "npx tsx src/bin/fix-activity-relations-memberId.ts",
     "lint": "npx eslint --ext .ts src --max-warnings=0",
     "format": "npx prettier --write \"src/**/*.ts\"",
     "format-check": "npx prettier --check .",

services/apps/script_executor_worker/src/types.ts

@@ -63,6 +63,5 @@ export interface IBlockOrganizationAffiliationArgs {
 }
 
 export interface IFixActivityRelationsMemberIdArgs extends IScriptBatchTestArgs {
-  bufferTargetSize?: number
   currentPlatformIndex?: number
 }

services/apps/script_executor_worker/src/workflows/fix-activityRelations-memberId.ts

@@ -18,72 +18,59 @@ export async function fixActivityRelationsMemberId(
   args: IFixActivityRelationsMemberIdArgs,
 ): Promise<void> {
   const BATCH_SIZE = args.batchSize ?? 500
-  const BUFFER_TARGET = args.bufferTargetSize ?? 50
 
-  // Always use all platforms every run
   const platforms = Object.values(PlatformType)
   let currentPlatformIndex = args.currentPlatformIndex ?? 0
 
-  const recordsBuffer = []
-
-  while (recordsBuffer.length < BUFFER_TARGET && currentPlatformIndex < platforms.length) {
-    const platform = platforms[currentPlatformIndex]
-
-    if (args.testRun) {
-      console.log('Current platform:', platform)
-    }
-
-    const records = await findMembersWithWrongActivityRelations(platform, BATCH_SIZE)
-
-    if (records.length === 0) {
-      console.log(`Platform ${platform} returned 0 results. Skipping.`)
-      currentPlatformIndex++ // Move to next platform
-      continue
-    }
-
-    // Fill buffer from this platform
-    const slotsLeft = BUFFER_TARGET - recordsBuffer.length
-    recordsBuffer.push(...records.slice(0, slotsLeft))
-  }
-
-  // No more platforms and empty buffer → stop workflow
-  if (recordsBuffer.length === 0) {
-    console.log('No more activity relations to fix!')
+  if (currentPlatformIndex >= platforms.length) {
+    console.log('All platforms exhausted. Workflow complete!')
     return
   }
 
-  // Process the batch (even if < BUFFER_TARGET)
-  await Promise.all(
-    recordsBuffer.map(async (record) => {
-      const correctMemberId = await findMemberIdByUsernameAndPlatform(
-        record.username,
-        record.platform,
-      )
-
-      if (args.testRun) {
-        console.log('Moving activity relations!', {
-          fromId: record.memberId,
-          toId: correctMemberId,
-          username: record.username,
-          platform: record.platform,
-        })
-      }
-
-      await moveActivityRelations(
-        record.memberId,
-        correctMemberId,
-        record.username,
-        record.platform,
-      )
-    }),
-  )
+  const platform = platforms[currentPlatformIndex]
+
+  if (args.testRun) console.log('Processing platform:', platform)
+
+  // Take a batch from current platform
+  const records = await findMembersWithWrongActivityRelations(platform, BATCH_SIZE)
+
+  if (records.length === 0) {
+    console.log(`Platform ${platform} has no more records. Moving to next platform.`)
+    currentPlatformIndex++
+  } else {
+    // Process the batch immediately
+    await Promise.all(
+      records.map(async (record) => {
+        const correctMemberId = await findMemberIdByUsernameAndPlatform(
+          record.username,
+          record.platform,
+        )
+
+        if (args.testRun) {
+          console.log('Moving activity relations!', {
+            fromId: record.memberId,
+            toId: correctMemberId,
+            username: record.username,
+            platform: record.platform,
+          })
+        }
+
+        await moveActivityRelations(
+          record.memberId,
+          correctMemberId,
+          record.username,
+          record.platform,
+        )
+      }),
+    )
+  }
 
   if (args.testRun) {
     console.log('Test run completed - stopping after first batch!')
     return
   }
 
-  // Continue workflow at the next platform
+  // Continue workflow for next batch (same platform or next platform)
   await continueAsNew<typeof fixActivityRelationsMemberId>({
     ...args,
     currentPlatformIndex,