Fix typos #551
Fix typos #551
Conversation
Diegovsky
left a comment
Diegovsky
left a comment
There was a problem hiding this comment.
looks good and simple enough
src/api/cache.rs
Outdated
| IgnoreExpiry, // always use cached value | ||
| Revalidate, // always query remote cache | ||
| IgnoreCached, // ignore cache alltogether | ||
| IgnoreCached, // ignore cache all together |
There was a problem hiding this comment.
Here, its actually altogether.
|
i can't really merge this myself, but I can say the changes are needed and should be merged. |
|
Could you please fix the merge conflicts? I don't think it could take much of your time. I apologise for the 3 year wait. |
|
With all due respect to xou816 and his awesome work, maybe it's a good time to hard fork this project... Not being able to merge anything, not even dependency bumps, has rendered the app completely unusable in 2025. |
|
it's something me and @knokelmaat have talked about. I'm at a bit of crossroads in life right now, meaning I can and am able to passively maintain and review, however I wouldn't be able to give spot the attention it needs. We definitely want to go the hard fork route. We have thought of a name also, but I wouldn't want to make the community suffer yet another irregular maintainer. I also gave some time for @xou816 to see if they were coming back as they had some GH activity end of last year, but it seems they aren't able to commit still. I'll keep you posted, hopefully I might open a new issue announcing this and part with a fork. I appreciate the interest after all this time :) |
|
I hope it all works out, @Diegovsky ! I'm looking forward to help in any way I can (currently exploring GTK via Python, looking to expand to Rust as well / can also provide translations, UI mockups, vector assets etc) |
|
We will definitely need all the support you all can give! Thank you for your patience and love for the software for all this time! As of today, I'm starting a new job and for a while will not be able to commit to anything serious while adjusting to the routine. When I'm ready, I'll make sure to announce it. |
|
Hey @Diegovsky How is it looking right now? I was also wondering about forking spot, because currently it looks largely unmaintained and there are still pretty crucial features missing and there is also some stuff i would like to implement, so if you are planning to make a fork, i would like to be apart of it |
Hey, sorry for pinging you again, but perhaps you missed my message, so im asking again, are you planning to fork this project? i would really be glad to help to maintan it / implement some of the missing features |
|
Sorry, I was pretty sure I had answered you! Github might have scrapped my response or something! As of right now, I have limited bandwidth to code, but am willing to deal with organization aspects such as reviews, flathub, github org, etc. Thankfully, college is on winter break until august 18, so I'm hopeful we can get a lot done until then. @knokelmaat are you able to join this new effort? |
Diegovsky
requested review from
Diegovsky
and removed request for
UnlimitedCookies
|
@UnlimitedCookies please accept the changes |
6 participants
Found via
codespell -S po -L crate,homestate,trough