Skip to content

fix: exclude build-sha.txt from plugin archives #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
josephfusco wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: exclude build-sha.txt from plugin archives #558

josephfusco wants to merge 2 commits into from

Conversation

@josephfusco
Copy link
Member

@josephfusco josephfusco commented Jan 8, 2026

Add /build-sha.txt and /.* patterns to archive exclusion list in hwp-previews and wpgraphql-logging composer.json files.

This fixes PR plugin artifacts failing to install in WordPress with "No valid plugins were found" error.

Closes #550

Description

Related Issue

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@josephfusco
fix: exclude build-sha.txt from plugin archives
66fc3e3 
Add /build-sha.txt and /.* patterns to archive exclusion list in
hwp-previews and wpgraphql-logging composer.json files.

This fixes PR plugin artifacts failing to install in WordPress with
"No valid plugins were found" error.

Closes #550
@josephfusco josephfusco requested a review from a team as a code owner January 8, 2026 21:20
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: ac5e6dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Jan 8, 2026 •
edited
Loading

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ hwp-previews.zip
  • ✅ wpgraphql-logging.zip
  • ✅ wpgraphql-webhooks.zip

See the "Artifacts" section at the bottom of the Actions run page

@josephfusco
fix: extract composer archive before artifact upload
ac5e6dc 
Fixes double-zip issue where downloaded GitHub Actions artifact
contained a nested zip file. WordPress only extracts one level,
so it couldn't find the plugin files.

Now the artifact upload receives the extracted directory, so the
downloaded artifact IS the plugin zip directly.

Closes #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PR plugin artifacts fail to install: "No valid plugins were found"

2 participants

@josephfusco