-
Notifications
You must be signed in to change notification settings - Fork 13
Ensure gateway title displayed. #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
f04d847 to
5dbebda
Compare
qasumitbagthariya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Update ✅
I have verified this PR in the fix/SQUARE-150-no-title-display branch, which has been fixed and is functioning as intended.
I tested the following on this branch:
Default titles for each payment methods is displayed.
Testing Environment
Details
- WordPress: 6.9
- Theme: Storefront 4.6.2
- Theme: Twenty Twenty-Five 1.4
- WooCommerce - 10.4.0
- PHP: 8.0.30
- Web Server: Nginx 1.20.2
- Browser: Chrome
- OS: macOS 15.2
- Branch: fix/SQUARE-150-no-title-display
Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for UAT
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:
- Yes
- Not Required/Applicable for this PR
All Submissions:
Changes proposed in this Pull Request:
Ensures the default gateway titles are displayed if not set in the options.
This fixes an issue in which check-out pages does not show any text for the payment method when the settings page for the gateway has not been visited by the merchant. This can happen if they click the enable button on WooCommerce > Settings > Payments page without clicking the manage button.
Closes https://linear.app/a8c/issue/SQUARE-150/checkout-title-does-not-display-prior-to-managing-and-saving-payment
Steps to test the changes in this Pull Request:
woocommerce_square_cash_app_pay_settingsandwoocommerce_square_credit_card_settings.Changelog entry