Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Nov 26, 2025

Closes WOOMOB-1644

Description

This PR handles creating the new POS promotional screenshots and submitting them to the App Store through our existing fastlane automation.

Changes

  • Added backgrounds and frames for landscape images
  • Updated fastfile to include the new mapping app_store_screenshot -> promo_screenshot
  • Updated screenshots.json to include a new landscape device, mostly mapping the existing portrait one. These are mounted programmatically by pixel/pixel-offset, but there is no references anywhere, so was a bit of iteration to make them fit adequately:
Screenshot 2025-12-16 at 11 56 42
  • iPad

    • Runs UI POS screenshot tests on iPads only
    • Intersects the new screenshots in the existing ones (mostly a dependency from UI tests having to be run in a given order)
    • Mounts background/frame/screenshot/text for the promotional screenshot
  • iPhones

    • Moves existing 1-5 iPhone screenshots to default folder
    • Updates which text to image mapping to use for 4th and 5th screenshots, due the new inclusion of iPad screenshots since we don't have the same number of them in each device now and would map the wrong text.

Test Steps

  • Run WooCommerceScreenshots.testScreenshots() both in iPad and iPhone as your run destination, they should pass (some UI tests are a bit flaky, but on a second run they should normally pass correctly)
  • The screenshot output cannot be tested locally, but we can find the artifacts from the CI job in ...

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added the generate screenshots Triggers a GitHub Action to generate screenshots for this PR. label Nov 27, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 28, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16405-fff2bb7
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commitfff2bb7
Installation URL61hoouttqke10
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Despite tests passing, the contents of the pos-payment screenshot was incorrect, as lands on the failure case for `checkOrderIsStillEligibleForPayment` when attempting to retrieve the order details, hence showing a “Error: unable to process payment. we could not fetch the latest order details” rather than the payment view.

Despite passing the CPP mock in the POSTabCoordinator, we were never setting it in the test as a launch argument.
Since we run the notification screenshot the last one due to the UI test flow, when we run the create_promo lane then screenshot descriptions are miss-aligned with what they show which fails the job.
At the moment we intersect POS screenshots, but “product-add” screenshot happens as the 7th, while in screenshots.js is set to be the 4rth. This fails the create_promo job as cannot find the correct index along the screenshot name
@iamgabrielma iamgabrielma removed the generate screenshots Triggers a GitHub Action to generate screenshots for this PR. label Dec 15, 2025
initial attempt to set the screenshot landscape composition programmatically. might need iteration after checking the result artifacts
@iamgabrielma iamgabrielma added the generate screenshots Triggers a GitHub Action to generate screenshots for this PR. label Dec 15, 2025
iPhone screenshots 4 and 5 are using the wrong text files because new POS screenshots are inserted into the sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generate screenshots Triggers a GitHub Action to generate screenshots for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants