[HACK][Woo POS] Modularization - move utils to /libs/pos module #15094

samiuelson · 2025-12-12T10:44:01Z

Description

This PR modularizes the Woo POS codebase by moving utility classes, data storage managers, and related test files from the main WooCommerce module to the /libs/pos module. This refactoring improves code organization and module separation.

Methodology:

Classes that were dependent only on woopos - specific dependencies were moved to libs/pos module altogether.
Classes that were dependent on store management dependencies were split between libs/commons and libs/pos.

💡 Do not merge until the parent branch is trunk and we make sure it will work fine with the automated strings translation process.

Test Steps

Verify CI is green
Smoke test the app

Images/gif

N/A

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

…ibs/pos`

dangermattic · 2025-12-12T10:44:53Z

	1 Error
🚫	This PR is tagged with `status: do not merge` label(s).

Generated by 🚫 Danger

wpmobilebot · 2025-12-12T10:49:12Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`6b0a17b`
	Direct Download	`woocommerce-wear-prototype-build-pr15094-6b0a17b.apk`

- Move `WooPosContextExt.kt` from the main app module to the `libs/pos` module. - Add `androidx.core.ktx` and `androidx.compose.ui.main` dependencies to `libs/pos/build.gradle`.

wpmobilebot · 2025-12-12T11:04:25Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`6b0a17b`
	Direct Download	`woocommerce-prototype-build-pr15094-6b0a17b.apk`

wpmobilebot · 2025-12-12T11:55:06Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

…tion-utils

- Move `WooPosGetStoreCountryName` and related string resources from the main app to `libs/pos`. - Add Dagger Hilt configuration to `libs/pos/build.gradle`.

…tion-utils

…nto hack-pos-modularization-utils

Copilot

Pull request overview

This PR modularizes the Woo POS codebase by moving utility classes, data storage managers, and related test files from the main WooCommerce module to the /libs/pos module. This refactoring improves code organization and module separation.

Key Changes

Created new utility classes in /libs/pos for POS-specific functionality including connection type detection, currency retrieval, and timestamp management
Moved and created DataStore-based repositories for managing POS preferences and sync timestamps
Added comprehensive test coverage for the moved/new utilities
Relocated country name string resources from main app to the POS module with localization support

Reviewed changes

Copilot reviewed 39 out of 61 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
libs/pos/build.gradle	Added Hilt plugin and dependencies for DataStore, Compose UI, Gson, and testing libraries
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/WooPosGetStoreCountryName.kt	Updated import to reference new R file location in pos module
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/WooPosGetCachedStoreCurrency.kt	New utility for caching and retrieving store currency
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/WooPosConnectionTypeProvider.kt	New utility for detecting network connection type (WiFi/Cellular/Unknown)
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/WooPosCellularCapabilityDetector.kt	New utility for detecting device cellular capability
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/WooPosTestTags.kt	New constants for UI testing tags
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampRepository.kt	New DataStore repository for managing sync timestamps
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/datastore/WooPosSyncTimestampManager.kt	New manager for formatting and parsing API timestamps
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/datastore/WooPosPreferencesRepository.kt	New DataStore repository for POS preferences and searches
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/ext/*.kt	New extension functions for Date, Context, and WindowInsetsCompat
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/util/format/Is24HourFormat.kt	New utility for checking 24-hour format preference
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/WooPOSIsRemotelyEnabled.kt	New use case for checking remote POS feature enablement
libs/pos/src/main/java/com/woocommerce/android/ui/woopos/common/util/WooPosCouldNotDetermineValueException.kt	New exception class for indeterminate values
libs/pos/src/test/java/*/.kt	Comprehensive test coverage for new utilities
libs/pos/src/main/res/values*/strings.xml	Relocated country name strings with translations for 18+ languages
libs/commons/src/main/java/com/woocommerce/android/util/WCSSRModelCachingFetcher.kt	New caching fetcher for WCSSR model with TTL-based cache
libs/commons/src/main/java/com/woocommerce/android/ui/woopos/util/*.kt	New common utilities for network status and country code retrieval
libs/commons/build.gradle	Added testFixtures dependency for fluxc-plugin
WooCommerce/src/main/res/values*/strings.xml	Removed country name strings (moved to libs/pos module)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-12T17:15:44Z

libs/pos/src/main/res/values-tr/strings.xml

+
+        <string name="woopos_eligibility_screen_UK_country_name">İngiltere</string>


The US country name string resource is missing from the Turkish translation file. All other language files include both woopos_eligibility_screen_US_country_name and woopos_eligibility_screen_UK_country_name, but this file only has the UK entry. This will cause issues if the US country name is needed in the Turkish locale.

The Turkish translation needs to be added. This is a pre-existing bug that was carried over during the modularization. The Turkish translation was incomplete in the original WooCommerce module - it only had the UK country name, never the US one. The PR simply moved what existed without introducing new missing translations.

…dependencies

samiuelson · 2025-12-12T18:27:09Z

libs/pos/src/main/res/values/strings.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="woopos_eligibility_screen_US_country_name">the United States</string>


When moving WooPosGetStoreCountryName to libs/pos module, the string resources were moved along with this class. Do you have an idea how this will be treated by our automated translation process during app release, @wzieba? I wonder if any new strings from the /libs/ modules are going to be processed the same way as from WooCommerce app module.

I think if we merge this as it is, the translation will be broken 😕. I'll research more on this topic later (I hope today) but please don't merge this for now.

Alright. Thanks for looking into that and researching 👍

…tion-utils

…tion-utils # Conflicts: # WooCommerce/src/main/res/values-de/strings.xml

…tion-utils

malinajirka

Looks good overall. However, I believe we'll need to update our tolling to handle the translations properly. Wojtek has a way better understanding there, so let's see what he thinks.

Move WooPosSyncTimestampManager and related DataStore classes to `l…

3bed020

…ibs/pos`

samiuelson added 4 commits December 12, 2025 12:03

Move WooPosContextExt.kt to the pos module and update dependencies

314c639

- Move `WooPosContextExt.kt` from the main app module to the `libs/pos` module. - Add `androidx.core.ktx` and `androidx.compose.ui.main` dependencies to `libs/pos/build.gradle`.

Move Is24HourFormat to pos module

e0e35db

Move WindowInsetsCompatExt.kt to the libs/pos module

aa6a742

Move WooPosCellularCapabilityDetector to the pos module

60d4666

samiuelson added 3 commits December 12, 2025 12:04

Move WooPosConnectionTypeProvider and its test to the pos module

81175eb

Move WooPosDateExt to pos module

d9ece64

Move WooPosTestTags to the pos library module

062e09c

samiuelson added 8 commits December 12, 2025 13:05

Move WooPosGetCachedStoreCurrency and its test to the pos module

7289ba0

Merge branch 'hack-modularize-selected-site' into hack-pos-modulariza…

6ce9477

…tion-utils

Migrate WooPosGetStoreCountryName to pos module

a873758

- Move `WooPosGetStoreCountryName` and related string resources from the main app to `libs/pos`. - Add Dagger Hilt configuration to `libs/pos/build.gradle`.

Move WooPosGetStoreCountryCode to the commons library

b73c0ed

Move WooPosNetworkStatus to the commons library

15741cb

Merge branch 'hack-modularize-selected-site' into hack-pos-modulariza…

0454f8c

…tion-utils

Merge remote-tracking branch 'origin/hack-pos-modularization-utils' i…

f2e16bb

…nto hack-pos-modularization-utils

Move WooPOSIsRemotelyEnabled and its dependencies to the commons

eaf627e

samiuelson changed the title ~~[Woo POS] Modularization - utils~~ [Woo POS] Modularization - move utils to /libs/pos module Dec 12, 2025

Remove comment

17c9503

samiuelson requested a review from Copilot December 12, 2025 17:10

samiuelson added this to the 24.0 milestone Dec 12, 2025

samiuelson added the type: task An internally driven task. label Dec 12, 2025

Copilot started reviewing on behalf of samiuelson December 12, 2025 17:12 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

Move WooPosCoroutineTestRule to commons test fixtures and update …

3a173d6

…dependencies

samiuelson commented Dec 12, 2025

View reviewed changes

samiuelson added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Dec 12, 2025

Merge branch 'hack-modularize-selected-site' into hack-pos-modulariza…

e52b752

…tion-utils

samiuelson marked this pull request as ready for review December 12, 2025 18:29

samiuelson requested review from malinajirka and wzieba December 12, 2025 18:29

samiuelson mentioned this pull request Dec 12, 2025

[HACK week] Modularization of SelectedSite #15086

Open

1 task

samiuelson added 2 commits December 12, 2025 22:42

Merge branch 'hack-modularize-selected-site' into hack-pos-modulariza…

74899bf

…tion-utils # Conflicts: # WooCommerce/src/main/res/values-de/strings.xml

Satisfy detekt's complaints

874e6aa

samiuelson changed the title ~~[Woo POS] Modularization - move utils to /libs/pos module~~ [HACK][Woo POS] Modularization - move utils to /libs/pos module Dec 15, 2025

Merge branch 'hack-modularize-selected-site' into hack-pos-modulariza…

6b0a17b

…tion-utils

malinajirka self-assigned this Dec 16, 2025

malinajirka reviewed Dec 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HACK][Woo POS] Modularization - move utils to /libs/pos module #15094

[HACK][Woo POS] Modularization - move utils to /libs/pos module #15094

Uh oh!

samiuelson commented Dec 12, 2025 •

edited

Loading

Uh oh!

dangermattic commented Dec 12, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 12, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 12, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 12, 2025

Uh oh!

samiuelson Dec 12, 2025

Uh oh!

samiuelson Dec 12, 2025

Uh oh!

wzieba Dec 16, 2025

Uh oh!

samiuelson Dec 16, 2025

Uh oh!

malinajirka left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		<string name="woopos_eligibility_screen_UK_country_name">İngiltere</string>

[HACK][Woo POS] Modularization - move utils to /libs/pos module #15094

Are you sure you want to change the base?

[HACK][Woo POS] Modularization - move utils to /libs/pos module #15094

Uh oh!

Conversation

samiuelson commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Images/gif

Uh oh!

dangermattic commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Build Failure Analysis

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

wzieba Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

samiuelson commented Dec 12, 2025 •

edited

Loading

dangermattic commented Dec 12, 2025 •

edited

Loading

wpmobilebot commented Dec 12, 2025 •

edited

Loading

wpmobilebot commented Dec 12, 2025 •

edited

Loading

wpmobilebot commented Dec 12, 2025 •

edited

Loading