Skip to content

[Woo POS][HACK week] Move ConnectionType and dependencies to pos module #15084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malinajirka merged 8 commits into from
Dec 16, 2025
Merged

[Woo POS][HACK week] Move ConnectionType and dependencies to pos module #15084

malinajirka merged 8 commits into from
Dec 16, 2025
+4 −0

Conversation

@samiuelson
Copy link
Contributor

@samiuelson samiuelson commented Dec 11, 2025 •
edited
Loading

Description

This PR moves ConnectionType and its dependencies to the pos module

Test Steps

🟢 Green CI

Images/gif

N/A

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@samiuelson samiuelson force-pushed the hack-modularize-connection-type branch from 174655b to e918bd3 Compare December 11, 2025 11:36
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 11, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6893ab0
Direct Downloadwoocommerce-wear-prototype-build-pr15084-6893ab0.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 11, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6893ab0
Direct Downloadwoocommerce-prototype-build-pr15084-6893ab0.apk

@samiuelson samiuelson requested a review from Copilot December 15, 2025 14:58
@samiuelson samiuelson added the type: task An internally driven task. label Dec 15, 2025
@samiuelson samiuelson added this to the 23.9 milestone Dec 15, 2025
@samiuelson samiuelson marked this pull request as ready for review December 15, 2025 15:05
Copilot AI reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@malinajirka malinajirka self-assigned this Dec 16, 2025
malinajirka
malinajirka approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malinajirka malinajirka merged commit b39fc31 into trunk Dec 16, 2025
25 checks passed
@malinajirka malinajirka deleted the hack-modularize-connection-type branch December 16, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@malinajirka malinajirka malinajirka approved these changes

Assignees

@malinajirka malinajirka

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.9

Development

Successfully merging this pull request may close these issues.

4 participants

@samiuelson @wpmobilebot @malinajirka