-
Notifications
You must be signed in to change notification settings - Fork 137
Migrate legacy Material Icons to Material Symbols #15081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate legacy Material Icons to Material Symbols #15081
Conversation
Generated by 🚫 Danger |
Project dependencies changeslist- Removed Dependencies
androidx.compose.material:material-icons-core:1.7.8
androidx.compose.material:material-icons-core-android:1.7.8
androidx.compose.material:material-icons-extended:1.7.8
androidx.compose.material:material-icons-extended-android:1.7.8tree-+--- androidx.compose:compose-bom:2025.11.00
-| +--- androidx.compose.material:material-icons-extended:1.7.8 (c)
-| +--- androidx.compose.material:material-icons-extended-android:1.7.8 (c)
-| +--- androidx.compose.material:material-icons-core:1.7.8 (c)
-| \--- androidx.compose.material:material-icons-core-android:1.7.8 (c)
-\--- androidx.compose.material:material-icons-extended -> 1.7.8
- \--- androidx.compose.material:material-icons-extended-android:1.7.8
- +--- androidx.compose.material:material-icons-core:1.7.8
- | \--- androidx.compose.material:material-icons-core-android:1.7.8
- | +--- androidx.compose.ui:ui:1.6.0 -> 1.9.4 (*)
- | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.2.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.2.21 (*) |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15081 +/- ##
============================================
- Coverage 38.53% 38.52% -0.01%
- Complexity 10397 10398 +1
============================================
Files 2173 2172 -1
Lines 123725 123758 +33
Branches 17050 17065 +15
============================================
+ Hits 47676 47679 +3
- Misses 71238 71269 +31
+ Partials 4811 4810 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ff19f3c to
42397cc
Compare
malinajirka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…cons # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/list/BookingListScreen.kt
Closes WOOMOB-1599
Description
Based in this recommendation, this PR removes the material-icons dependency and replaces all usages with their equivalents from Google Font Icons.
The diff is large, but the review should not be too difficult. This PR only updates icon resources. The main things to watch for during review are:
Note
@malinajirka and @samiuelson, I’m also requesting your review since Hicham and Adam are AFK and this PR is project-wide but a single reviewer should be enough.
Notes
Filledtoggle, and I made sure to download the correct variant to preserve the look of the previous icon.Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.