Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 9, 2025

WOOMOB-1854

Description

Clean up the codebase after moving card reader connection to WooPos-specific implementation:

  • Remove WooPosCardReaderActivity (replaced by new connection dialog)
  • Update WooPosCardReaderFacade to use new connection flow
  • Remove POS-specific branches from payments cardreader package
  • Update related tests

Test Steps

  1. Code review only - verifies cleanup doesn't break existing functionality
  2. Smoke test IPP connection/payment flows
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 9, 2025

1 Error
🚫 This PR is tagged with status: do not merge label(s).
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kidinov kidinov changed the title [WOOMOB-1854] Remove POS-related code from payments and clean up card reader [WOOMOB-1854] PR 5/6: Remove POS-related code from payments and clean up Dec 9, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit912a394
Direct Downloadwoocommerce-wear-prototype-build-pr15073-912a394.apk

@kidinov kidinov force-pushed the woomob-1854-pr5-cleanup branch from 228dd5e to 912a394 Compare December 9, 2025 08:37
@kidinov kidinov changed the title [WOOMOB-1854] PR 5/6: Remove POS-related code from payments and clean up [WOOMOB-1854] PR 5/5: Remove POS-related code from payments and clean up Dec 9, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit912a394
Direct Downloadwoocommerce-prototype-build-pr15073-912a394.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.18%. Comparing base (1105aa1) to head (912a394).

Files with missing lines Patch % Lines
.../statuschecker/CardReaderStatusCheckerViewModel.kt 33.33% 2 Missing ⚠️
...ts/methodselection/SelectPaymentMethodViewModel.kt 0.00% 2 Missing ⚠️
...reader/onboarding/CardReaderOnboardingViewModel.kt 0.00% 1 Missing ⚠️
...ce/android/ui/payments/hub/PaymentsHubViewModel.kt 0.00% 1 Missing ⚠️
...oid/ui/woopos/cardreader/WooPosCardReaderFacade.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             woomob-1854-pr4-integration   #15073   +/-   ##
==============================================================
  Coverage                          38.18%   38.18%           
+ Complexity                         10364    10362    -2     
==============================================================
  Files                               2173     2173           
  Lines                             124600   124569   -31     
  Branches                           17251    17246    -5     
==============================================================
- Hits                               47575    47569    -6     
+ Misses                             72219    72196   -23     
+ Partials                            4806     4804    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kidinov kidinov requested a review from malinajirka December 9, 2025 09:56
@kidinov kidinov added Enhancement status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Dec 9, 2025
@kidinov kidinov marked this pull request as ready for review December 9, 2025 09:57
@kidinov kidinov changed the title [WOOMOB-1854] PR 5/5: Remove POS-related code from payments and clean up [HACK][Woo POS] PR 5/5: Remove POS-related code from payments and clean up Dec 10, 2025
@malinajirka malinajirka added this to the 23.9 milestone Dec 16, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thorough testing will be done later.

We'll need to verify tracking events are consistent with iOS

@malinajirka malinajirka self-assigned this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature: POS Hack Week status: do not merge Dependent on another PR, ready for review but not ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants