Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 9, 2025

WOOMOB-1854

Description

Add the UI layer for WooPos card reader connection:

  • Connection dialog with all state views (scanning, found, connecting, updating, errors)
  • ViewModel that bridges the controller to the UI
  • Onboarding activity for payment setup
  • String resources for all dialog states

Test Steps

  1. Code review only - integration with home screen is in the next PR. Use compose previews as well
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 9, 2025

2 Errors
🚫 Please add tests for class WooPosCardReaderConnectionViewModel (or add unit-tests-exemption label to ignore this).
🚫 This PR is tagged with status: do not merge label(s).
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

Project manifest changes for WooCommerce

The following changes in the WooCommerce's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt	2025-12-09 08:19:56.435194212 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt	2025-12-09 08:20:02.055220396 +0000
@@ -218,7 +218,7 @@
             android:theme="@style/Theme.WooPos"
             android:windowSoftInputMode="adjustResize" />
         <activity
-            android:name="com.woocommerce.android.ui.woopos.cardreader.WooPosCardReaderActivity"
+            android:name="com.woocommerce.android.ui.woopos.cardreader.WooPosCardReaderOnboardingActivity"
             android:theme="@style/Theme.WooPos.Transparent"
             android:windowSoftInputMode="adjustResize" />
         <activity

Go to https://buildkite.com/automattic/woocommerce-android/builds/34305/canvas?sid=019b022d-bbba-4366-86ca-f7358de9da48, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd84f687
Direct Downloadwoocommerce-wear-prototype-build-pr15071-d84f687.apk

@kidinov kidinov added this to the 24.0 milestone Dec 9, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd84f687
Direct Downloadwoocommerce-prototype-build-pr15071-d84f687.apk

@kidinov kidinov changed the title [WOOMOB-1854] Add WooPos card reader connection dialog and ViewModel [WOOMOB-1854] PR 3/6: Add WooPos card reader connection dialog and ViewModel Dec 9, 2025
@kidinov kidinov changed the title [WOOMOB-1854] PR 3/6: Add WooPos card reader connection dialog and ViewModel [WOOMOB-1854] PR 3/5: Add WooPos card reader connection dialog and ViewModel Dec 9, 2025
@kidinov kidinov requested a review from malinajirka December 9, 2025 09:53
@kidinov kidinov marked this pull request as ready for review December 9, 2025 09:54
@kidinov kidinov added status: do not merge Dependent on another PR, ready for review but not ready for merge. Hack Week labels Dec 9, 2025
@malinajirka malinajirka self-assigned this Dec 10, 2025
@kidinov kidinov changed the title [WOOMOB-1854] PR 3/5: Add WooPos card reader connection dialog and ViewModel [HACK][Woo POS] PR 3/5: Add WooPos card reader connection dialog and ViewModel Dec 10, 2025
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thorough testing will be done later.

@malinajirka malinajirka modified the milestones: 24.0, 23.9 Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature: POS Hack Week status: do not merge Dependent on another PR, ready for review but not ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants