Open
Conversation
kojiws
requested changes
Jan 20, 2026
kojiws
requested changes
Jan 21, 2026
anhu
requested changes
Jan 21, 2026
Member
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
In each \brief section it says "This macro...."
While its true they are macros, I think it should say "This function..." or method or something else.
Contributor
Author
On the same token, do you think it would be good to eliminate the wc_Dilithium_xxx lines?
|
Member
|
Yes. Eventually, that mapping will go away. Its an implementation detail, not an interface detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe the scope of the fix or feature addition.
Fixes zd#
Testing
How did you test?
Checklist