fix: wire ignoreAntialiasing to pixelmatch AA forgiveness toggle#1175
Open
wswebcreation wants to merge 1 commit into
Open
fix: wire ignoreAntialiasing to pixelmatch AA forgiveness toggle#1175wswebcreation wants to merge 1 commit into
wswebcreation wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c8676cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v10 the pixelmatch engine always ran with anti-aliasing forgiveness enabled, even when
ignoreAntialiasingwasfalse. The option had no effect on comparison behaviour.What changed
ignoreAntialiasingnow toggles pixelmatch's AA handling:trueforgives anti-aliased pixels,falsecounts them as mismatches.ignoreAntialiasing: true, matching the forgiving pixelmatch behaviour users already get in v10.ignoreLessandignoreNothingkeep their own threshold behaviour; AA forgiveness is controlled independently viaignoreAntialiasing.Migration
ignoreAntialiasing: truetoday, that remains redundant but harmless.ignoreAntialiasing: falsewhen you need strict comparison where anti-aliased pixels count as differences.