fix(Dockerfile): initialize git repo in VMAF source to satisfy vcstagger#604
fix(Dockerfile): initialize git repo in VMAF source to satisfy vcstagger#604cyberjames wants to merge 1 commit intowader:masterfrom
Conversation
Initialize a minimal git repository after extracting the VMAF tarball so that Meson’s git describe step works properly. This prevents the fatal error due to missing .git data.
|
Hi, could you elaborate more? i'm a bit confused as it seems to build fine as it is. But i do see this in the build log but it seem to not fail the build? but maybe some version string ends up wrong or empty because of it, but is that string exposed somewhere via the ffmpeg cli tools? For what i can see vmaf does not do "proper" source distributions of releases that embed the version? the "source code" link on github will download a git tag. |
|
@cyberjames could you provide some more details? |
|
Hey @wader , sorry for the delay! I was trying to remember the exact error but didn’t manage to capture the full logs. I was mainly focused on adding those changes in the Dockerfile since it looked similar to what you posted. Happy to cancel this PR if it’s not needed, just let me know what you reckon. |
|
No worries. So |
Summary:
This PR fixes the build error in the Dockerfile by initializing a minimal git repository in the VMAF source directory. The issue occurred during the Meson step (vcstagger) because the tarball lacked a .git folder.
Changes:
Testing:
I built the image locally (using Podman on an Apple M3 Pro) and confirmed that the build now completes successfully without errors.