Skip to content

Conversation

@vitess-bot
Copy link
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....

cc @vitessio/release

@vitess-bot vitess-bot added the Component: General Changes throughout the code base label Oct 15, 2025
@vitess-bot vitess-bot added go Type: Dependencies Dependency updates labels Oct 15, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot requested a review from a team October 15, 2025 00:20
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 15, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Oct 15, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 16, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vitess-bot vitess-bot force-pushed the upgrade-go-deps-on-main branch from 98ec660 to c018c4e Compare November 1, 2025 00:22
@timvaillancourt timvaillancourt self-requested a review November 5, 2025 16:17
@timvaillancourt
Copy link
Contributor

@frouioui should we backport this to release-23.0?

@frouioui
Copy link
Member

frouioui commented Nov 5, 2025

@timvaillancourt, we usually only do it on main, but this is likely a bad habit 😄 Should be fine to backport to 23

@timvaillancourt
Copy link
Contributor

@timvaillancourt, we usually only do it on main, but this is likely a bad habit 😄 Should be fine to backport to 23

@frouioui good to know. I guess what I'm really asking was: should this have been part of v23? If not, I think we can skip the backport

@frouioui
Copy link
Member

frouioui commented Nov 5, 2025

@timvaillancourt, I missed that this PR is 3 weeks old. I think we wouldn't have backported it to release-23.0 anyway, this PR got created a week after the creation of release-23.0 and the code freeze (#18729).

I am fine only merging this to main

@arthurschreiber
Copy link
Member

Should this bot be running independently on all supported release branches, so that we can bump their dependencies individually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants