fix: mount Svelte example and CLI template with Svelte 5 API#99
Open
mliem2k wants to merge 1 commit into
Open
Conversation
The svelte example and the native init Svelte scaffold both called
new App({ target }), the Svelte 4 component constructor. Svelte 5
removed it, so every checkout of examples/svelte and every freshly
generated Svelte project throws component_api_invalid_new on load.
Switch both to mount(App, { target }) from the svelte package.
Fixes vercel-labs#48
|
@mliem2k is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/svelte/frontend/src/main.jsand thenative initSvelte scaffold (svelteMainJs()insrc/tooling/templates.zig) both callednew App({ target }), the Svelte 4 component constructor.^5.55.5) removed that constructor, so both the checked-out example and every freshly generated Svelte project throwcomponent_api_invalid_newon load, as reported in Svelte example doesn't work #48.mount(App, { target })from thesveltepackage. Added a changelog fragment per CONTRIBUTING.md.Fixes #48
Test plan
bun install && bun run buildinexamples/svelte/frontendbuilds cleanlyzig build testpasses (exit code 0)