feat: add SolidJS example#104
Open
mliem2k wants to merge 1 commit into
Open
Conversation
|
@mliem2k is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Add examples/solid, mirroring the existing React/Vue/Svelte example shape (app.zon, hand-owned build.zig, Vite dev server, native dev/run/test) with a SolidJS frontend using createSignal/onMount and solid-js/web's render(). Wired into zig build test-examples-frontends and documented in examples/README.md and the frontend docs page. Closes vercel-labs#57
mliem2k
force-pushed
the
feat/solid-example
branch
from
64f0d5e to
0e583a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/solid, mirroring the existing React/Vue/Svelte example shape:app.zon, hand-ownedbuild.zig/build.zig.zon,native dev/run/test, and a Vite dev server on127.0.0.1:5173.createSignal/onMountandsolid-js/web'srender(), the standard Solid + Vite pattern (vite-plugin-solid).zig build test-examples-frontends(newtest-example-solidstep + positioning check) and documented inexamples/README.mdanddocs/src/app/frontend/page.mdx.native init --frontend solidCLI template. That would additionally touch theFrontendenum and everywrite*function insrc/tooling/templates.zig, a larger change; happy to follow up if maintainers want full CLI parity.Closes #57
Test plan
zig build test-example-solidpasseszig build test-examples-frontendspasses (includes the new positioning check)zig build testpasses (exit 0)bun install && bun run buildinexamples/solid/frontendbuilds cleanly