fix(healthcheck): use documented retry defaults#25743
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small follow-up split out from review feedback on #25662.
It changes
HealthConfig::default()to match the same retry defaults already used when deserializingHealthConfigfrom config:retry_initial_backoff_secs:1retry_max_duration_secs:3600sWithout this, code paths that construct a missing health config with
HealthConfig::default()get zero retry timing values instead of the documented/deserialized defaults.Change Type
Is this a breaking change?
How Has This Been Tested?
cargo fmt --all -- --checkcargo test sinks::util::service::health::tests::health_config_default_matches_deserialize_defaults --libcargo test sinks::util::service::health::tests::test_health_counters --lib./scripts/check_changelog_fragments.shChecklist