Skip to content

fix(healthcheck): use documented retry defaults#25743

Merged
pront merged 2 commits into
vectordotdev:masterfrom
fpytloun:fix-healthconfig-defaults
Jul 2, 2026
Merged

fix(healthcheck): use documented retry defaults#25743
pront merged 2 commits into
vectordotdev:masterfrom
fpytloun:fix-healthconfig-defaults

Conversation

@fpytloun

@fpytloun fpytloun commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This is a small follow-up split out from review feedback on #25662.

It changes HealthConfig::default() to match the same retry defaults already used when deserializing HealthConfig from config:

  • retry_initial_backoff_secs: 1
  • retry_max_duration_secs: 3600s

Without this, code paths that construct a missing health config with HealthConfig::default() get zero retry timing values instead of the documented/deserialized defaults.

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation update
  • Other

Is this a breaking change?

  • Yes
  • No

How Has This Been Tested?

  • cargo fmt --all -- --check
  • cargo test sinks::util::service::health::tests::health_config_default_matches_deserialize_defaults --lib
  • cargo test sinks::util::service::health::tests::test_health_counters --lib
  • ./scripts/check_changelog_fragments.sh

Checklist

  • I have read the contributing guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an appropriate changelog entry

@fpytloun fpytloun requested a review from a team as a code owner July 2, 2026 15:37
@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Jul 2, 2026

@pront pront left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pront pront enabled auto-merge July 2, 2026 16:42
@pront pront added this pull request to the merge queue Jul 2, 2026
Merged via the queue into vectordotdev:master with commit ac50b4c Jul 2, 2026
60 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants