chore(http client): Make HttpClient generic over connector#25742
Open
guilload wants to merge 1 commit into
Open
chore(http client): Make HttpClient generic over connector#25742guilload wants to merge 1 commit into
HttpClient generic over connector#25742guilload wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a475bcf19
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
guilload
changed the title
HttpClient generic over connectorHttpClient generic over connector
pront
added
the
no-changelog
Author
|
I have read the CLA Document and I hereby sign the CLA |
thomasqueirozb
changed the title
HttpClient generic over connectorHttpClient generic over connector
guilload
force-pushed
the
guilload/http-client-over-generic-connector
branch
from
8a475bc to
f82c41c
Compare
guilload
force-pushed
the
guilload/http-client-over-generic-connector
branch
from
f82c41c to
816d695
Compare
pront
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
HttpClientgeneric over the connector (hyper::client::connect::Connect) so it can be customized to support use cases that are not relevant to the broader OSS community.Change Type
Non-functional refactoring.
Is this a breaking change?
This is a non-functional change. Call sites remain unchanged and the current connector remains the default one.
Does this PR include user facing changes?
No.