chore(deps): bump the tonic group across 1 directory with 2 updates#25717
chore(deps): bump the tonic group across 1 directory with 2 updates#25717dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2313999795
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-health = { version = "0.14", default-features = false } | ||
| tonic-reflection = { version = "0.14", default-features = false, features = ["server"] } |
There was a problem hiding this comment.
Keep tonic helper crates in sync with tonic
With the default base/sources-vector or api features enabled, this mixes tonic-health/tonic-reflection 0.14 (their lockfile entries now depend on tonic 0.14.5) with the workspace's unchanged tonic/tonic-build 0.11. The existing callers pass these services/clients into 0.11 APIs such as TonicServer::builder().add_service(...) and RoutesBuilder::add_service(...), so the health/reflection types come from a different tonic crate and no longer satisfy those bounds; bump the whole tonic/prost stack together or keep these helper crates at 0.11.
Useful? React with 👍 / 👎.
4c90b87 to
e413b57
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e413b57b0b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tonic-health = { version = "0.11", default-features = false } | ||
| tonic-reflection = { version = "0.11", default-features = false, features = ["server"] } | ||
| tonic-health = { version = "0.14", default-features = false } | ||
| tonic-reflection = { version = "0.14", default-features = false, features = ["server"] } |
There was a problem hiding this comment.
Update reflection builder call for 0.14
When the api feature is enabled, this pulls in tonic-reflection 0.14, whose server Builder no longer exposes .build()—it uses build_v1/build_v1alpha instead. The API server still calls .build() in src/api/grpc_server.rs:90, so the default/base build fails as soon as this dependency is selected; either keep reflection at 0.11 or update that call while doing the tonic upgrade.
Useful? React with 👍 / 👎.
e413b57 to
7e62193
Compare
Bumps the tonic group with 2 updates in the / directory: [tonic-health](https://github.com/hyperium/tonic) and [tonic-reflection](https://github.com/hyperium/tonic). Updates `tonic-health` from 0.11.0 to 0.14.5 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.11.0...v0.14.5) Updates `tonic-reflection` from 0.11.0 to 0.14.5 - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/grpc/grpc-rust/blob/master/CHANGELOG.md) - [Commits](grpc/grpc-rust@v0.11.0...v0.14.5) --- updated-dependencies: - dependency-name: tonic-health dependency-version: 0.14.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic - dependency-name: tonic-reflection dependency-version: 0.14.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tonic ... Signed-off-by: dependabot[bot] <support@github.com>
7e62193 to
8b2b9c4
Compare
Bumps the tonic group with 2 updates in the / directory: tonic-health and tonic-reflection.
Updates
tonic-healthfrom 0.11.0 to 0.14.5Changelog
Sourced from tonic-health's changelog.
... (truncated)
Commits
3f7caf3chore: prepare v0.14.5 release (#2516)3f56644grpc(chore): add missing copyright notices (#2513)1769c91feat(xds): implement xDS subscription worker (#2478)56f8c6dfeat(grpc): Add TCP listener API in the Runtime trait + tests for server cred...149f366feat(grpc) Add channel credentials API + Insecure credentials (#2495)cd5b32fchore: prepare 0.14.4 release (#2504)27640d2fix(web): allow space after:ingrpc-status(#2506)0c26ee1Fix permission of a series of files (#2502)c25daa6fix(ci): remove comment from manifest to unblock version parsing (#2501)3efc5f9chore(doc): Replace doc_auto_cfg config with doc_cfg (#2428)Updates
tonic-reflectionfrom 0.11.0 to 0.14.5Changelog
Sourced from tonic-reflection's changelog.
... (truncated)
Commits
3f7caf3chore: prepare v0.14.5 release (#2516)3f56644grpc(chore): add missing copyright notices (#2513)1769c91feat(xds): implement xDS subscription worker (#2478)56f8c6dfeat(grpc): Add TCP listener API in the Runtime trait + tests for server cred...149f366feat(grpc) Add channel credentials API + Insecure credentials (#2495)cd5b32fchore: prepare 0.14.4 release (#2504)27640d2fix(web): allow space after:ingrpc-status(#2506)0c26ee1Fix permission of a series of files (#2502)c25daa6fix(ci): remove comment from manifest to unblock version parsing (#2501)3efc5f9chore(doc): Replace doc_auto_cfg config with doc_cfg (#2428)