*.go: move the carrierd archive/tar to internal/#79
Merged
Conversation
Owner
Author
|
cc @tojoos from #76 (comment) discussion |
The feature of golang having source in a project path with "internal" makes the code only able to be imported by the project itself. https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/edit?tab=t.0 Since we have this carried version of `archive/tar` with our byte accounting patches, it is also means the version of archive/tar has not kept up with upstream. our tar-split libraries do not even utilize all the function calls of our carried archive/tar, so might as well limit anyone else in the world from calling them as well. Signed-off-by: Vincent Batts <[email protected]>
|
@vbatts Yeah, this would be great to limit potential issues with components that are not used by project itself and shouldn't be used by anyone importing vbatts. This way potential |
vbatts
added a commit
that referenced
this pull request
Jan 29, 2025
rev'ing a Y stream version because this release only has the change of making the forked version of `archive/tar` now an internal library. Since tar-split is not even using _all_ the logic in these libraries, might as well limit folks ability to import from this aging code. Reference: #79 Signed-off-by: Vincent Batts <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature of golang having source in a project path with "internal" makes the code only able to be imported by the project itself.
https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/edit?tab=t.0
Since we have this carried version of
archive/tarwith our byte accounting patches, it is also means the version of archive/tar has not kept up with upstream.our tar-split libraries do not even utilize all the function calls of our carried archive/tar, so might as well limit anyone else in the world from calling them as well.