feat mysql: add secure connection option impl #1083
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation of
use_secure_connectionfor mysql driver. Previously this flag was introduced in settings but was not used at all. Mainly we use only one flag of underlyinglibmariadb-connector-c:MYSQL_OPT_SSL_VERIFY_SERVER_CERT, which tells do not verify SSL certificates.It is very useful in testing env where mysql database is running inside of docker container and there is no need to worry about SSL.
P.S. sample service was working fine because mysql database was running on localhost and in this case libmariadb using a unix socket and no SSL needed at all.