Fix CI#430
Open
Gliese852 wants to merge 4 commits into
Open
Conversation
chenjun1982
approved these changes
Mar 16, 2026
JPeisach
reviewed
Jul 22, 2026
| seat->path = g_strdup_printf ("/org/freedesktop/login1/seat/%s", seat->id); | ||
| seat->can_graphical = TRUE; | ||
| seat->can_multi_session = TRUE; | ||
| seat->can_tty = TRUE; |
Collaborator
There was a problem hiding this comment.
So the tests do pass when this is set to true, but other than that, is there a reason this should be set to true by default?
| seat_set_property (seat, "exit-on-failure", "true"); | ||
|
|
||
| /* in the absence of login1 we find out this using our own heuristics */ | ||
| seat_set_can_tty (seat, vt_can_multi_seat ()); |
Collaborator
There was a problem hiding this comment.
Could this lead to false results (where CanTTY is set to false?)
I don't think not being multiseat implies not being able to TTY a single seat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand, after #315 a significant number of tests broke. This was mostly due to the fact that the
CanTTYproperty introduced in the PR was not added to the test dbus interface. Also, recently the actions stopped running completely becauseactions/upload-artifact@v3was deprecated.Updated to
actions/upload-artifact@v4and fixed the problem withcan_tty.