fix(build-index): include sub-manifest blobs for multi-arch replication#637
Draft
thijmv wants to merge 2 commits into
Draft
fix(build-index): include sub-manifest blobs for multi-arch replication#637thijmv wants to merge 2 commits into
thijmv wants to merge 2 commits into
Conversation
thijmv
force-pushed
the
thijmv/replication-sub-blobs
branch
from
1a9dbfe to
b4ab7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #619 by adding recursion to dependency resolution in the tag replication executor only, ensuring multi-arch images are replicated completely, while leaving the validation path untouched.
Context
Currently, the dependency resolver does not traverse more than one layer, meaning that for multi-arch images, their nested dependencies are not considered for tag uploads or replication.
Therefore, the dependency validation on tag uploads became stricter in #620, by making
Resolve()recurse into sub-manifests for both validation and replication. However, this was reverted, as uBuild can push images to different zones, meaning nested blob validation started failing.The decision has been made to not validate the nested dependencies when the tag of a multi-arch image is uploaded, because it is already done indirectly. That is, when the sub-manifests are uploaded, their dependencies are validated. This means that when the multi-arch manifest is uploaded, only the top-level sub-manifests are considered for indirect validation.